[svn:parrot] r36234 - trunk/lib/Parrot

[petdance at svn.parrot.org]

Author: petdance
Date: Sun Feb  1 07:06:21 2009
New Revision: 36234
URL: https://trac.parrot.org/parrot/changeset/36234

Log:
little Critic changes

Modified:
   trunk/lib/Parrot/BuildUtil.pm
   trunk/lib/Parrot/Headerizer.pm
   trunk/lib/Parrot/Manifest.pm

Modified: trunk/lib/Parrot/BuildUtil.pm
==============================================================================
--- trunk/lib/Parrot/BuildUtil.pm	Sun Feb  1 06:48:24 2009	(r36233)
+++ trunk/lib/Parrot/BuildUtil.pm	Sun Feb  1 07:06:21 2009	(r36234)
@@ -96,8 +96,8 @@
 sub generated_file_header {
     my ( $filename, $style ) = @_;
 
-    die "unknown style '$style'"
-        if $style !~ m/\A(perl|c)\z/;
+    die qq{unknown style "$style"}
+        if $style !~ m/\A(?:perl|c)\z/;
 
     require File::Spec;
     my $script = File::Spec->abs2rel($0);

Modified: trunk/lib/Parrot/Headerizer.pm
==============================================================================
--- trunk/lib/Parrot/Headerizer.pm	Sun Feb  1 06:48:24 2009	(r36233)
+++ trunk/lib/Parrot/Headerizer.pm	Sun Feb  1 07:06:21 2009	(r36234)
@@ -238,6 +238,8 @@
     my $error = shift;
 
     push( @{ $warnings{$file}->{$func} }, $error );
+
+    return;
 }
 
 1;

Modified: trunk/lib/Parrot/Manifest.pm
==============================================================================
--- trunk/lib/Parrot/Manifest.pm	Sun Feb  1 06:48:24 2009	(r36233)
+++ trunk/lib/Parrot/Manifest.pm	Sun Feb  1 07:06:21 2009	(r36234)
@@ -113,7 +113,7 @@
     $print_str .= $text_file_coda;
     open my $MANIFEST, '>', $self->{file}
         or croak "Unable to open $self->{file} for writing";
-    print $MANIFEST $print_str;
+    print {$MANIFEST} $print_str;
     close $MANIFEST or croak "Unable to close $self->{file} after writing";
 
     return 1;