[svn:parrot] r37688 - in trunk: lib/Parrot/Harness t/codingstd

[coke at svn.parrot.org]

Author: coke
Date: Tue Mar 24 20:55:58 2009
New Revision: 37688
URL: https://trac.parrot.org/parrot/changeset/37688

Log:
[t] run all the codingstd tests when running 'make codetest'

I think the original reason to keep these separate was to keep 'codetest' lean
and runnable as part of 'make test' - since we don't do that anymore, just
todo these tests as we would any other.

Modified:
   trunk/lib/Parrot/Harness/DefaultTests.pm
   trunk/t/codingstd/c_function_docs.t
   trunk/t/codingstd/c_todo.t
   trunk/t/codingstd/pod_description.t
   trunk/t/codingstd/pod_todo.t

Modified: trunk/lib/Parrot/Harness/DefaultTests.pm
==============================================================================
--- trunk/lib/Parrot/Harness/DefaultTests.pm	Tue Mar 24 19:38:41 2009	(r37687)
+++ trunk/lib/Parrot/Harness/DefaultTests.pm	Tue Mar 24 20:55:58 2009	(r37688)
@@ -85,9 +85,7 @@
 
 @developing_tests = ( 't/distro/file_metadata.t' );
 # Add in all t/codingstd except for a few skips.
-push @developing_tests,
-  grep { ! m/(c_function_docs|c_todo|pod_description|pod_todo)\.t$/ }
-  glob 't/codingstd/*.t';
+push @developing_tests, glob 't/codingstd/*.t';
 
 sub get_default_tests {
     my ($core_tests_only, $runcore_tests_only) = @_;

Modified: trunk/t/codingstd/c_function_docs.t
==============================================================================
--- trunk/t/codingstd/c_function_docs.t	Tue Mar 24 19:38:41 2009	(r37687)
+++ trunk/t/codingstd/c_function_docs.t	Tue Mar 24 20:55:58 2009	(r37688)
@@ -83,6 +83,8 @@
     }
 }
 
+TODO: {
+    local $TODO = 'not all functions are documented yet.';
 if ( @ARGV == 1 ) {
     ok( !scalar(@missing_docs), 'Functions documented' )
         or diag( "Number of functions lacking documentation = "
@@ -97,6 +99,7 @@
             . " files:\n at missing_docs\n"
             . "Use tools/docs/func_boilerplate.pl to add missing documentation\n" );
 }
+}
 
 # Local Variables:
 #   mode: cperl

Modified: trunk/t/codingstd/c_todo.t
==============================================================================
--- trunk/t/codingstd/c_todo.t	Tue Mar 24 19:38:41 2009	(r37687)
+++ trunk/t/codingstd/c_todo.t	Tue Mar 24 20:55:58 2009	(r37688)
@@ -59,12 +59,16 @@
 }
 
 my $num_failed_files = scalar keys %failed_files;
+TODO: {
+    local $TODO = 'some todos remain';
+
 ok( !scalar(@fixme), 'FIXME strings' )
     or diag( "FIXME strings found in "
         . scalar @fixme
         . " instances in "
         . $num_failed_files
         . " files:\n at fixme" );
+}
 
 # Local Variables:
 #   mode: cperl

Modified: trunk/t/codingstd/pod_description.t
==============================================================================
--- trunk/t/codingstd/pod_description.t	Tue Mar 24 19:38:41 2009	(r37687)
+++ trunk/t/codingstd/pod_description.t	Tue Mar 24 20:55:58 2009	(r37688)
@@ -47,11 +47,15 @@
 my $empty_description_files = join( "\n", sort @empty_description);
 my $nempty_description      = scalar( @empty_description );
 
+TODO: {
+    local $TODO = 'not everything has a DESCRIPTION';
+
 is(
     $empty_description_files,
     q{},
     'All Pod files have non-empty DESCRIPTION sections'
 );
+}
 
 diag("\nFound $nempty_description files without DESCRIPTION sections.\n")
     if $nempty_description;

Modified: trunk/t/codingstd/pod_todo.t
==============================================================================
--- trunk/t/codingstd/pod_todo.t	Tue Mar 24 19:38:41 2009	(r37687)
+++ trunk/t/codingstd/pod_todo.t	Tue Mar 24 20:55:58 2009	(r37688)
@@ -31,6 +31,9 @@
 my $nbad_files = scalar @{ $need_testing_ref };
 
 # only ok if everything passed
+TODO: {
+    local $TODO = 'some todo remain';
+
 is(
     $bad_files,
     q{},
@@ -39,6 +42,7 @@
 
 diag("\nFound $nbad_files files with 'todo', 'fixme' or 'XXX' items.\n")
     if $nbad_files;
+}
 
 =head1 NAME