[svn:parrot] r38027 - in trunk: src/gc t/pmc

whiteknight at svn.parrot.org whiteknight at svn.parrot.org
Fri Apr 10 17:48:15 UTC 2009


Author: whiteknight
Date: Fri Apr 10 17:48:14 2009
New Revision: 38027
URL: https://trac.parrot.org/parrot/changeset/38027

Log:
Finally resolve RT#46719. One of the tests was using ge instead of isge, which miraculously produced a passing test using the old initialized register values. Fixing the test enables us to avoid initialization

Modified:
   trunk/src/gc/register.c
   trunk/t/pmc/managedstruct.t

Modified: trunk/src/gc/register.c
==============================================================================
--- trunk/src/gc/register.c	Fri Apr 10 15:37:59 2009	(r38026)
+++ trunk/src/gc/register.c	Fri Apr 10 17:48:14 2009	(r38027)
@@ -272,8 +272,7 @@
     }
 
     if (Interp_debug_TEST(interp, PARROT_REG_DEBUG_FLAG)) {
-        /* depending on -D40 we set int, num to garbage different garbage
-         * RT #46179 remove this code for parrot 1.0 */
+        /* depending on -D40 we set int and num to be identifiable garbage values */
         for (i = 0; i < ctx->n_regs_used[REGNO_INT]; i++) {
             CTX_REG_INT(ctx, i) = -999;
         }
@@ -281,14 +280,6 @@
             CTX_REG_NUM(ctx, i) = -99.9;
         }
     }
-    else {
-        for (i = 0; i < ctx->n_regs_used[REGNO_INT]; i++) {
-            CTX_REG_INT(ctx, i) = -888;
-        }
-        for (i = 0; i < ctx->n_regs_used[REGNO_NUM]; i++) {
-            CTX_REG_NUM(ctx, i) = -88.8;
-        }
-    }
 }
 
 

Modified: trunk/t/pmc/managedstruct.t
==============================================================================
--- trunk/t/pmc/managedstruct.t	Fri Apr 10 15:37:59 2009	(r38026)
+++ trunk/t/pmc/managedstruct.t	Fri Apr 10 17:48:14 2009	(r38027)
@@ -81,7 +81,7 @@
     push $P2, 0
     new $P0, ['ManagedStruct'], $P2
     set $I0, $P0
-    $I1 = ge $I0, 2
+    $I1 = isge $I0, 2
     ok($I1, "ManagedStruct size is at least 2")
 
     set $P0[0;0], 1


More information about the parrot-commits mailing list