[svn:parrot] r38500 - trunk/config/gen/makefiles

[petdance at svn.parrot.org]

Author: petdance
Date: Wed May  6 05:31:44 2009
New Revision: 38500
URL: https://trac.parrot.org/parrot/changeset/38500

Log:
still organizing splitn flags

Modified:
   trunk/config/gen/makefiles/root.in

Modified: trunk/config/gen/makefiles/root.in
==============================================================================
--- trunk/config/gen/makefiles/root.in	Wed May  6 05:02:55 2009	(r38499)
+++ trunk/config/gen/makefiles/root.in	Wed May  6 05:31:44 2009	(r38500)
@@ -1944,16 +1944,60 @@
     +posix-strict-lib \
     -skip-posix-headers \
     \
+    +ansi89-limits \
+    \
     -show-summary \
     +show-scan \
-    +time-dist \
-    \
-    +memchecks \
-    \
-    -ansi-reserved \
+    +time-dist
+
+# Watch for naming conflicts, but don't complain about str*() functions
+SPLINTFLAGS := $(SPLINTFLAGS) \
+    +ansi-reserved \
     +ansi-reserved-internal \
-    +bool-compare \
+    -iso-reserved \
+    -iso-reserved-internal
+
+# Memory safety checks
+SPLINTFLAGS := $(SPLINTFLAGS) \
     +bufferoverflow \
+    +bufferoverflowhigh \
+
+# Macro safety checks
+SPLINTFLAGS := $(SPLINTFLAGS) \
+    +macro-assign \
+    +macro-empty \
+    +macro-parens \
+    +macro-redef \
+    +macro-stmt \
+    +macro-unrecog \
+
+# Watch for unsafe comparisons
+SPLINTFLAGS := $(SPLINTFLAGS) \
+    +bool-compare \
+    +ptr-compare \
+    +real-compare \
+    +unsigned-compare
+
+# But allow us some slop in boolean comparisons
+SPLINTFLAGS := $(SPLINTFLAGS) \
+    -pred-bool-int \
+    -pred-bool-ptr \
+    -pred-bool-others \
+    -boolops \
+
+# Pointer arithmetic is OK, but watch for null pointers
+SPLINTFLAGS := $(SPLINTFLAGS) \
+    -ptr-arith \
+    +nullptrarith \
+    +ptr-negate
+
+# Check on consistency of defs
+SPLINTFLAGS := $(SPLINTFLAGS) \
+    +incon-defs \
+    +incon-defs-lib \
+
+# The rest of the flags to be organized.
+SPLINTFLAGS := $(SPLINTFLAGS) \
     +char-index \
     +cpp-names \
     +decl-undef \
@@ -1964,44 +2008,16 @@
     +format-code \
     +format-type \
     +ignore-signs \
-    +incon-defs \
-    +incon-defs-lib \
-    -iso-reserved \
-    +macro-assign \
-    +macro-empty \
-    +macro-parens \
-    +macro-redef \
-    +macro-stmt \
-    +macro-unrecog \
     +match-fields \
-    -memchecks \
     +null \
-    +nullptrarith \
     +nullret \
-    -pred-bool-int \
-    -pred-bool-ptr \
-    -pred-bool-others \
-    +ptr-compare \
-    +ptr-negate \
     +strict-destroy \
     \
     +use-released \
     +strict-use-released \
-
-# I'd like the +ignore-signs to go away, but we have too many
-# cross-signedness comparisons.
-
-# Andy is working on making a decent splint target.  He's currently
-# (2/29/08) dropping all the flags that he's been working with
-# and going with the +weak settings, just to get the most egregious
-# problems uncovered.  Then, he'll be gradually adding stricter and
-# stricter settings.  The SPLINTFLAGS_OVERLY_NOISY list below represents
-# his noisy-based work at the time he reverted to weak mode.
-SPLINTFLAGS_OVERLY_NOISY := \
     -abstract \
     +aliasunique \
     +assignexpose \
-    -boolops \
     -casebreak \
     -castfcnptr \
     -charint \
@@ -2013,8 +2029,6 @@
     -globs \
     +imptype \
     -initallelements \
-    -isoreserved \
-    -isoreservedinternal \
     +longintegral \
     +matchanyintegral \
     +nestedextern \
@@ -2022,7 +2036,6 @@
     -paramuse \
     +ptrnegate \
     +readonlystrings \
-    -realcompare \
     -redef \
     -retvalint \
     -retvalother \
@@ -2037,7 +2050,6 @@
     -compdestroy \
     -compmempass \
     -globstate \
-    -modobserver \
     -mustfreefresh \
     -mustfreeonly \
     -nullstate \
@@ -2053,6 +2065,7 @@
     -temptrans \
     -unqualifiedtrans \
 
+
 # Other options we'd like to add back
 # +paramuse: As soon as we get SHIM()s in the ops
 # -includedepth 8 : Let's investigate why we do so many includes.
@@ -2060,23 +2073,13 @@
 #  values of the arrays
 # +casebreak: Auto-generated ops have way too case fallthrus right now
 # +noeffect: Right now the UNUSED(macro) trips +noeffect
-# +realcompare: Make sure we're not doing comparisons on equality on real
-#  numbers
 # +fcnuse: We have many functions that are defined but not used, but they
 #  should get hidden or ifdeffed
 # +redef, +redecl: Ops currently have tons of redefinitions
-# +boolops
 
 # added to splint target to simplify experimentation,
 # ex: make SPLINTFLAGS_TEST='-posixstrictlib +posixlib' splint
 
-
-# We're only checking part of the codebase, and don't try to track memory leaks
-SPLINTFLAGS_TEST := +partial -memchecks
-
-# Don't complain about the str*() functions being reserved by the standard
-SPLINTFLAGS_TEST := $(SPLINTFLAGS_TEST) -iso-reserved-internal
-
 # Don't complain about using pointers and ints as booleans
 SPLINTFLAGS_TEST := $(SPLINTFLAGS_TEST) -pred-bool
 
@@ -2088,7 +2091,7 @@
 splint-andy :
 	$(MKPATH) $(SPLINT_TMP)
 	splint $(CC_INC) @cc_hasjit@ -DNDEBUG "-Isrc/pmc" "-Icompilers/ast" $(SPLINTFLAGS) $(SPLINTFLAGS_TEST) \
-	+partial \
+	+partial -memchecks \
 	src/s*.c \
     | grep -v 'Source code error generation point'