[svn:parrot] r39647 - in branches/pmc_pct/compilers/pmcc/src: . emitter

[cotto at svn.parrot.org]

Author: cotto
Date: Thu Jun 18 08:02:58 2009
New Revision: 39647
URL: https://trac.parrot.org/parrot/changeset/39647

Log:
[pmcc] make a freeze sub, remove unnecessary commenting from inline POD

Modified:
   branches/pmc_pct/compilers/pmcc/src/builtins.pir
   branches/pmc_pct/compilers/pmcc/src/emitter/pmc.pm

Modified: branches/pmc_pct/compilers/pmcc/src/builtins.pir
==============================================================================
--- branches/pmc_pct/compilers/pmcc/src/builtins.pir	Thu Jun 18 07:57:30 2009	(r39646)
+++ branches/pmc_pct/compilers/pmcc/src/builtins.pir	Thu Jun 18 08:02:58 2009	(r39647)
@@ -127,6 +127,12 @@
     .return ($I0)
 .end
 
+.sub 'freeze'
+    .param pmc p
+    $S0 = freeze p
+    .return ($S0)
+.end
+
 # Extend various Parrot's PMCs to play nicely with NQP.
 .namespace ['Hash']
 

Modified: branches/pmc_pct/compilers/pmcc/src/emitter/pmc.pm
==============================================================================
--- branches/pmc_pct/compilers/pmcc/src/emitter/pmc.pm	Thu Jun 18 07:57:30 2009	(r39646)
+++ branches/pmc_pct/compilers/pmcc/src/emitter/pmc.pm	Thu Jun 18 08:02:58 2009	(r39647)
@@ -3,11 +3,11 @@
 
 class PMC::Emitter::PMC;
 
-# =item C<generate_header>
-#
-# Generate part of header file.
-#
-# =cut
+=item C<generate_header>
+
+Generate part of header file.
+
+=cut
 
 # "Template Method". Just override generate_header_functions in derived
 # classes.
@@ -38,11 +38,11 @@
     $res
 }
 
-# =item C<generate_header_functions>
-#
-# Generate C declarations for vtable functions
-#
-# =cut
+=item C<generate_header_functions>
+
+Generate C declarations for vtable functions
+
+=cut
 
 method generate_header_functions() {
     my $past := self.past;
@@ -61,11 +61,11 @@
     join('', @res_builder);
 }
 
-#=item C<generate_attr_struct>
-#
-#Generate a C declaration for the ATTR wrapper struct
-#
-#=cut
+=item C<generate_attr_struct>
+
+Generate a C declaration for the ATTR wrapper struct
+
+=cut
 
 method generate_attr_struct() {
 
@@ -98,11 +98,11 @@
     return $struct_start ~ join('', @struct_members) ~ $struct_end;
 }
 
-#=item C<generate_casting_macro>
-#
-#Generate a #define to simplify ATTR access
-#
-#=cut
+=item C<generate_casting_macro>
+
+Generate a #define to simplify ATTR access
+
+=cut
 
 method generate_casting_macro() {
 
@@ -117,11 +117,11 @@
 }
 
 
-#=item C<generate_attr_accessors>
-#
-#Generate a macros to manipulate ATTRs
-#
-#=cut
+=item C<generate_attr_accessors>
+
+Generate a macros to manipulate ATTRs
+
+=cut
 
 method generate_attr_accessors() {
 
@@ -292,36 +292,23 @@
               \"subclassed from a high-level PMC.\"); \\";
 }
 
-#=item C<generate_dump_file>
-#
-#Generate the contents of a dump file for this PMC, which will contain any
-#information that's needed for determining inheritance.
-#
-#=cut
+=item C<generate_dump_file>
+
+Generate the contents of a dump file for this PMC, which will contain any
+information that's needed for determining inheritance.
+
+=cut
 
 method generate_dump() {
-    my $res := self.freeze_attrs();
+    my $res := freeze(self.attrs);
 }
 
-method freeze_attrs() {
-    my $frozen;
 
-    #IWBNI nqp exposed freeze directly, but this is works too
-PIR q<
-    $P0 = self.'attrs'()
-    $S0 = freeze $P0
-    $P0 = find_lex '$frozen'
-    $P0 = $S0
->;
-    return $frozen;
-}
+=item C<generate_c_code>
 
+Generate C file's contents for this PMC.
 
-#=item C<generate_c_code>
-#
-#Generate C file's contents for this PMC.
-#
-#=cut
+=cut
 
 method generate_c_code($past) {
     self.pre_method_gen();
@@ -332,11 +319,11 @@
 }
 
 
-#=item C<generate_c_functions>
-#
-#Generate C declarations for vtable functions
-#
-#=cut
+=item C<generate_c_functions>
+
+Generate C declarations for vtable functions
+
+=cut
 
 method generate_c_functions() {
     my $past    := self.past;