[svn:parrot] r40299 - trunk/src/gc

[chromatic at svn.parrot.org]

Author: chromatic
Date: Tue Jul 28 07:49:48 2009
New Revision: 40299
URL: https://trac.parrot.org/parrot/changeset/40299

Log:
[GC] Moved a pointer dereference after the check for its NULLness (Coverity CID
#407).

Modified:
   trunk/src/gc/alloc_register.c

Modified: trunk/src/gc/alloc_register.c
==============================================================================
--- trunk/src/gc/alloc_register.c	Tue Jul 28 07:44:59 2009	(r40298)
+++ trunk/src/gc/alloc_register.c	Tue Jul 28 07:49:48 2009	(r40299)
@@ -668,11 +668,12 @@
     ASSERT_ARGS(Parrot_context_ref_trace)
     if (Interp_debug_TEST(interp, PARROT_CTX_DESTROY_DEBUG_FLAG)) {
         const char *name = "unknown";
-        Parrot_sub *sub;
 
-        PMC_get_sub(interp, ctx->current_sub, sub);
-        if (ctx->current_sub)
+        if (ctx->current_sub) {
+            Parrot_sub *sub;
+            PMC_get_sub(interp, ctx->current_sub, sub);
             name = (char *)(sub->name->strstart);
+        }
 
         fprintf(stderr, "[reference to context %p ('%s') taken at %s:%d]\n",
                 (void *)ctx, name, file, line);