[svn:parrot] r40741 - in trunk/src: . gc pmc
whiteknight at svn.parrot.org
whiteknight at svn.parrot.org
Sun Aug 23 15:30:51 UTC 2009
Author: whiteknight
Date: Sun Aug 23 15:30:50 2009
New Revision: 40741
URL: https://trac.parrot.org/parrot/changeset/40741
Log:
[pmc] remove more references to PMC_EXT, mostly comments
Modified:
trunk/src/gc/api.c
trunk/src/gc/mark_sweep.c
trunk/src/packdump.c
trunk/src/pmc.c
trunk/src/pmc/scalar.pmc
Modified: trunk/src/gc/api.c
==============================================================================
--- trunk/src/gc/api.c Sun Aug 23 15:20:12 2009 (r40740)
+++ trunk/src/gc/api.c Sun Aug 23 15:30:50 2009 (r40741)
@@ -385,7 +385,7 @@
=item C<void Parrot_gc_free_pmc_sync(PARROT_INTERP, PMC *p)>
-Frees the C<PMC_EXT> structure attached to a PMC, if it exists.
+Frees the PMC_sync field of the PMC, if one exists.
=cut
Modified: trunk/src/gc/mark_sweep.c
==============================================================================
--- trunk/src/gc/mark_sweep.c Sun Aug 23 15:20:12 2009 (r40740)
+++ trunk/src/gc/mark_sweep.c Sun Aug 23 15:30:50 2009 (r40741)
@@ -390,10 +390,8 @@
=item C<void mark_special(PARROT_INTERP, PMC *obj)>
-Marks the children of a special PMC. Handles the marking necessary
-for shared PMCs, and ensures timely marking of high-priority PMCs.
-Ensures PMC_EXT structures are properly organized for garbage
-collection.
+Handles marking a PMC. Specifically, calls the VTABLE_mark for that PMC
+if one is present. Also handles marking shared PMCs.
=cut
@@ -762,8 +760,7 @@
PObj *p)>
Frees a PMC that is no longer being used. Calls a custom C<destroy> VTABLE
-method if one is available. If the PMC uses a PMC_EXT structure, that is freed
-as well.
+method if one is available.
=cut
@@ -1011,7 +1008,7 @@
=item C<void initialize_header_pools(PARROT_INTERP)>
The initialization routine for the interpreter's header pools. Initializes
-pools for string headers, constant string headers, buffers, PMCs, PMC_EXTs, and
+pools for string headers, constant string headers, buffers, PMCs and
constant PMCs.
The C<string_header_pool> actually lives in the
Modified: trunk/src/packdump.c
==============================================================================
--- trunk/src/packdump.c Sun Aug 23 15:20:12 2009 (r40740)
+++ trunk/src/packdump.c Sun Aug 23 15:30:50 2009 (r40741)
@@ -100,7 +100,6 @@
"private7",
"is_string",
"is_PMC",
- "is_PMC_EXT",
"is_shared",
"constant",
"external",
@@ -116,7 +115,6 @@
"report",
"data_is_PMC_array",
"need_finalize",
- "is_special_PMC",
"high_priority_gc",
"needs_early_gc",
"is_class",
Modified: trunk/src/pmc.c
==============================================================================
--- trunk/src/pmc.c Sun Aug 23 15:20:12 2009 (r40740)
+++ trunk/src/pmc.c Sun Aug 23 15:30:50 2009 (r40741)
@@ -222,7 +222,6 @@
if (PObj_active_destroy_TEST(pmc))
VTABLE_destroy(interp, pmc);
- /* we are a PMC + maybe is_PMC_EXT */
PObj_flags_SETTO(pmc, PObj_is_PMC_FLAG | new_flags);
/* Set the right vtable */
@@ -285,7 +284,6 @@
if (PObj_active_destroy_TEST(pmc))
VTABLE_destroy(interp, pmc);
- /* we are a PMC + maybe is_PMC_EXT */
PObj_flags_SETTO(pmc, PObj_is_PMC_FLAG | new_flags);
/* Set the right vtable */
Modified: trunk/src/pmc/scalar.pmc
==============================================================================
--- trunk/src/pmc/scalar.pmc Sun Aug 23 15:20:12 2009 (r40740)
+++ trunk/src/pmc/scalar.pmc Sun Aug 23 15:30:50 2009 (r40741)
@@ -1374,7 +1374,7 @@
/* first set readonly */
VTABLE_setprop(INTERP, ret, CONST_STRING(INTERP, "_ro"), _true);
- /* now share; we add a PMC_EXT so we can identify the owning interp */
+ /* We're sharing this, so make sure it has a PMC_sync */
Parrot_gc_add_pmc_sync(INTERP, ret);
PObj_is_PMC_shared_SET(ret);
More information about the parrot-commits
mailing list