[svn:parrot] r41224 - in trunk/src: jit/i386 pmc

chromatic at svn.parrot.org chromatic at svn.parrot.org
Sat Sep 12 10:54:49 UTC 2009


Author: chromatic
Date: Sat Sep 12 10:54:48 2009
New Revision: 41224
URL: https://trac.parrot.org/parrot/changeset/41224

Log:
[PMC] Removed unnecessary custom_destroy flag setting on PMCs that don't have
their own destroy VTABLE entries anymore.

Modified:
   trunk/src/jit/i386/jit_defs.c
   trunk/src/pmc/continuation.pmc
   trunk/src/pmc/exception.pmc
   trunk/src/pmc/exceptionhandler.pmc

Modified: trunk/src/jit/i386/jit_defs.c
==============================================================================
--- trunk/src/jit/i386/jit_defs.c	Sat Sep 12 05:42:50 2009	(r41223)
+++ trunk/src/jit/i386/jit_defs.c	Sat Sep 12 10:54:48 2009	(r41224)
@@ -2413,8 +2413,9 @@
     jit_emit_stack_frame_leave(pc);
     emitm_ret(pc);
     PARROT_ASSERT(pc - jit_info.arena.start <= JIT_ALLOC_SIZE);
+
     /* could shrink arena.start here to used size */
-    PObj_custom_destroy_SET(pmc_nci);
+
     if (sizeptr)
         *sizeptr = JIT_ALLOC_SIZE;
     Parrot_str_free_cstring(signature_str);

Modified: trunk/src/pmc/continuation.pmc
==============================================================================
--- trunk/src/pmc/continuation.pmc	Sat Sep 12 05:42:50 2009	(r41223)
+++ trunk/src/pmc/continuation.pmc	Sat Sep 12 10:54:48 2009	(r41224)
@@ -76,8 +76,7 @@
         attrs->address    = NULL;
         attrs->current_results = Parrot_pcc_get_results(interp, attrs->to_ctx);
 
-        PObj_active_destroy_SET(SELF);
-        PObj_custom_mark_destroy_SETALL(SELF);
+        PObj_custom_mark_SET(SELF);
 
         /* PANIC("don't do that"); */
         /*
@@ -101,8 +100,7 @@
         attrs->address    = theirs->address;
         attrs->current_results = Parrot_pcc_get_results(interp, attrs->to_ctx);
 
-        PObj_active_destroy_SET(SELF);
-        PObj_custom_mark_destroy_SETALL(SELF);
+        PObj_custom_mark_SET(SELF);
 
         /* PANIC("don't do that"); */
         /*

Modified: trunk/src/pmc/exception.pmc
==============================================================================
--- trunk/src/pmc/exception.pmc	Sat Sep 12 05:42:50 2009	(r41223)
+++ trunk/src/pmc/exception.pmc	Sat Sep 12 10:54:48 2009	(r41224)
@@ -84,7 +84,6 @@
 
     VTABLE void init() {
         /* Set flags for custom GC mark and destroy. */
-        PObj_custom_destroy_SET(SELF);
         PObj_custom_mark_SET(SELF);
 
         SET_ATTR_severity(INTERP, SELF, EXCEPT_error);
@@ -124,7 +123,6 @@
         }
 
         /* Set flags for custom GC mark. */
-        PObj_custom_destroy_SET(SELF);
         PObj_custom_mark_SET(SELF);
 
         /* Set up the core struct and default values for the exception object. */

Modified: trunk/src/pmc/exceptionhandler.pmc
==============================================================================
--- trunk/src/pmc/exceptionhandler.pmc	Sat Sep 12 05:42:50 2009	(r41223)
+++ trunk/src/pmc/exceptionhandler.pmc	Sat Sep 12 10:54:48 2009	(r41224)
@@ -83,7 +83,6 @@
         if (attrs->handled_types_except){
             PObj_on_free_list_SET((PObj *) attrs->handled_types_except);
         }
-        SUPER();
     }
 
     VTABLE PMC *clone() {


More information about the parrot-commits mailing list