[svn:parrot] r41597 - in branches/pcc_reapply: include/parrot src/call

allison at svn.parrot.org allison at svn.parrot.org
Thu Oct 1 20:32:12 UTC 2009


Author: allison
Date: Thu Oct  1 20:32:10 2009
New Revision: 41597
URL: https://trac.parrot.org/parrot/changeset/41597

Log:
[pcc] Remove unused 'caller_sig' element in context struct. The maintenance and
execution cost of copying the pointer to the caller's CallSignature object in
all the appropriate places outweighs the cost of accessing it via caller_ctx.

Modified:
   branches/pcc_reapply/include/parrot/context.h
   branches/pcc_reapply/src/call/context.c

Modified: branches/pcc_reapply/include/parrot/context.h
==============================================================================
--- branches/pcc_reapply/include/parrot/context.h	Thu Oct  1 20:05:21 2009	(r41596)
+++ branches/pcc_reapply/include/parrot/context.h	Thu Oct  1 20:32:10 2009	(r41597)
@@ -111,7 +111,6 @@
 
     INTVAL                 current_HLL;     /* see also src/hll.c */
 
-    PMC *caller_sig;            /* CallSignature PMC that invoked this context*/
     PMC *current_sig;           /* temporary CallSignature PMC for active call */
     UINTVAL                warns;           /* Keeps track of what warnings
                                              * have been activated */

Modified: branches/pcc_reapply/src/call/context.c
==============================================================================
--- branches/pcc_reapply/src/call/context.c	Thu Oct  1 20:05:21 2009	(r41596)
+++ branches/pcc_reapply/src/call/context.c	Thu Oct  1 20:32:10 2009	(r41597)
@@ -1197,8 +1197,7 @@
     ctx->handlers          = PMCNULL;
     ctx->caller_ctx        = NULL;
     ctx->pred_offset       = 0;
-    ctx->caller_sig        = NULL;
-    ctx->current_sig       = NULL;
+    ctx->current_sig       = PMCNULL;
 
     if (old) {
         /* some items should better be COW copied */
@@ -1212,7 +1211,6 @@
         /* end COW */
         ctx->recursion_depth   = old->recursion_depth;
         ctx->caller_ctx        = pmcold;
-        ctx->caller_sig        = old->current_sig;
     }
     else {
         ctx->constants         = NULL;


More information about the parrot-commits mailing list