[svn:parrot] r41939 - branches/pcc_reapply/t/pmc

allison at svn.parrot.org allison at svn.parrot.org
Mon Oct 19 11:54:37 UTC 2009


Author: allison
Date: Mon Oct 19 11:54:35 2009
New Revision: 41939
URL: https://trac.parrot.org/parrot/changeset/41939

Log:
[pcc] Don't compare the constants table to the namespace, as the namespace is
cloned with all its contents, while the constants table isn't. See TT #1120.

Modified:
   branches/pcc_reapply/t/pmc/threads.t

Modified: branches/pcc_reapply/t/pmc/threads.t
==============================================================================
--- branches/pcc_reapply/t/pmc/threads.t	Mon Oct 19 09:22:55 2009	(r41938)
+++ branches/pcc_reapply/t/pmc/threads.t	Mon Oct 19 11:54:35 2009	(r41939)
@@ -687,6 +687,7 @@
     push @todo, ( todo => 'Broken with JIT' ) if $ENV{TEST_PROG_ARGS} =~ /--runcore=jit/;
     push @todo, ( todo => 'Broken with switch core' )  if $ENV{TEST_PROG_ARGS} =~ /--runcore=switch/;
 }
+# Direct constant access to sub objects commented out, see TT #1120.
 pir_output_unlike( <<'CODE', qr/not/, "globals + constant table subs issue", @todo );
 .namespace [ 'Foo' ]
 
@@ -749,7 +750,7 @@
 .end
 
 .sub check_sanity
-    _check_sanity( 'direct call' )
+#    _check_sanity( 'direct call' )
     $P0 = get_global '_check_sanity'
     $P0( 'call from get_global' )
     $P0 = get_hll_global [ 'Foo' ], '_check_sanity'
@@ -764,7 +765,7 @@
 
 .sub check_value
     .param int value
-    _check_value(value)
+#    _check_value(value)
     $P0 = get_global '_check_value'
     $P0(value)
     $P0 = get_hll_global [ 'Foo' ], '_check_value'
@@ -772,10 +773,19 @@
 .end
 
 .sub full_check
-    .const 'Sub' c_setup = 'setup'
-    .const 'Sub' c_sanity = 'check_sanity'
-    .const 'Sub' c_mutate = 'mutate'
-    .const 'Sub' c_value = 'check_value'
+#    .const 'Sub' c_setup = 'setup'
+#    .const 'Sub' c_sanity = 'check_sanity'
+#    .const 'Sub' c_mutate = 'mutate'
+#    .const 'Sub' c_value = 'check_value'
+
+    .local pmc c_setup
+    c_setup = get_global  'setup'
+    .local pmc c_sanity
+    c_sanity = get_global 'check_sanity'
+    .local pmc c_mutate
+    c_mutate = get_global 'mutate'
+    .local pmc c_value
+    c_value = get_global  'check_value'
 
     .local pmc g_setup
     g_setup = get_hll_global [ 'Foo' ], 'setup'


More information about the parrot-commits mailing list