[svn:parrot] r42409 - trunk/t/op

jkeenan at svn.parrot.org jkeenan at svn.parrot.org
Tue Nov 10 23:41:40 UTC 2009


Author: jkeenan
Date: Tue Nov 10 23:41:39 2009
New Revision: 42409
URL: https://trac.parrot.org/parrot/changeset/42409

Log:
Eliminate dependence on Perl 5 '%Config' in tests.  Cf.:  https://trac.parrot.org/parrot/ticket/1235.

Modified:
   trunk/t/op/sysinfo.t

Modified: trunk/t/op/sysinfo.t
==============================================================================
--- trunk/t/op/sysinfo.t	Tue Nov 10 23:38:12 2009	(r42408)
+++ trunk/t/op/sysinfo.t	Tue Nov 10 23:41:39 2009	(r42409)
@@ -116,18 +116,15 @@
     }
 }
 
-# 5 & 6
-if ( $PConfig{osname} eq 'MSWin32' ) {
-    # Windows 5 & 6
+SKIP:
+{
+    $PConfig{osname} eq 'MSWin32'
+        or skip "Tests only meaningful on Win32", 2;
     SKIP:
     {
         eval { require Win32; } or
             skip "requires package Win32 for these tests", 2;
 
-        # specifically don't use $Config{osvers}
-        # because it probably was the system perl was compiled on
-        # and we can do much better than that
-
         my $osname = Win32::GetOSName();
         $osname = 'WinXP' if $osname =~ m/^WinXP/;
         TODO: {
@@ -145,31 +142,9 @@
     print S1
 end
 CODE
-        }
-    }
-}
-else {
-    # Other 5 & 6
-
-    # XXX I know this is wrong on Win32 but is it correct on any others?
-    # XXX also should it be %Config or %PConfig
-    TODO:
-    {
-        local $TODO = "Not Currently Implemented";
-
-        pasm_output_is( <<'CODE', $Config{osvers}, "sysinfo OS version string" );
-    sysinfo_s_ic S1, 5
-    print S1
-end
-CODE
-
-        pasm_output_is( <<'CODE', $Config{osvers}, "sysinfo OS version number string" );
-    sysinfo_s_ic S1, 6
-    print S1
-end
-CODE
-    }
-}
+        } # END TODO block
+    } # END inner SKIP block
+} # END outer SKIP block
 
 SKIP:
 {


More information about the parrot-commits mailing list