[svn:parrot] r43032 - branches/pmc_freeze_cleanup/src/pmc

plobsing at svn.parrot.org plobsing at svn.parrot.org
Mon Dec 14 07:00:49 UTC 2009


Author: plobsing
Date: Mon Dec 14 07:00:48 2009
New Revision: 43032
URL: https://trac.parrot.org/parrot/changeset/43032

Log:
change all external accesses to visit_info.what to use get_integer

also, eliminate ParrotInterpreter setting visit_info.what because ...
well ... I'm not quite sure what it does, but it seems very, very wrong.

Modified:
   branches/pmc_freeze_cleanup/src/pmc/orderedhash.pmc
   branches/pmc_freeze_cleanup/src/pmc/parrotinterpreter.pmc

Modified: branches/pmc_freeze_cleanup/src/pmc/orderedhash.pmc
==============================================================================
--- branches/pmc_freeze_cleanup/src/pmc/orderedhash.pmc	Mon Dec 14 05:40:03 2009	(r43031)
+++ branches/pmc_freeze_cleanup/src/pmc/orderedhash.pmc	Mon Dec 14 07:00:48 2009	(r43032)
@@ -627,7 +627,7 @@
 */
 
     VTABLE void visit(visit_info *info) {
-        switch (info->what) {
+        switch (VTABLE_get_integer(INTERP, info)) {
           case VISIT_THAW_NORMAL:
           case VISIT_THAW_CONSTANTS:
             SUPER(info);
@@ -656,7 +656,7 @@
           default:
             Parrot_ex_throw_from_c_args(interp, NULL,
                     EXCEPTION_INVALID_OPERATION,
-                    "unhandled visit action (%d)", info->what);
+                    "unhandled visit action (%d)", VTABLE_get_integer(INTERP, info));
         }
     }
 }

Modified: branches/pmc_freeze_cleanup/src/pmc/parrotinterpreter.pmc
==============================================================================
--- branches/pmc_freeze_cleanup/src/pmc/parrotinterpreter.pmc	Mon Dec 14 05:40:03 2009	(r43031)
+++ branches/pmc_freeze_cleanup/src/pmc/parrotinterpreter.pmc	Mon Dec 14 07:00:48 2009	(r43032)
@@ -708,8 +708,8 @@
          */
 
         /*  HLL_info */
-        if (info->what == VISIT_THAW_NORMAL ||
-                info->what == VISIT_THAW_CONSTANTS) {
+        if (VTABLE_get_integer(INTERP, info) == VISIT_THAW_NORMAL ||
+                VTABLE_get_integer(INTERP, info) == VISIT_THAW_CONSTANTS) {
             pos = &PMC_args(SELF);
         }
         else
@@ -733,7 +733,6 @@
             }
 
             PMC_interp(SELF) = INTERP;
-            info->what       = VISIT_THAW_CONSTANTS;
         }
     }
 


More information about the parrot-commits mailing list