[svn:parrot] r43348 - in branches/pmc_freeze_cleanup: src t/pmc

[plobsing at svn.parrot.org]

Author: plobsing
Date: Thu Dec 31 20:37:41 2009
New Revision: 43348
URL: https://trac.parrot.org/parrot/changeset/43348

Log:
re-todo eval.thaw test (TT#1142), eliminate workaround in visit_loop_todo_list

Modified:
   branches/pmc_freeze_cleanup/src/pmc_freeze.c
   branches/pmc_freeze_cleanup/t/pmc/eval.t

Modified: branches/pmc_freeze_cleanup/src/pmc_freeze.c
==============================================================================
--- branches/pmc_freeze_cleanup/src/pmc_freeze.c	Thu Dec 31 19:14:20 2009	(r43347)
+++ branches/pmc_freeze_cleanup/src/pmc_freeze.c	Thu Dec 31 20:37:41 2009	(r43348)
@@ -734,11 +734,6 @@
     const int    thawing        = info->what == VISIT_THAW_CONSTANTS
                                || info->what == VISIT_THAW_NORMAL;
 
-    /* XXX As the name suggests, this pmc is useless. However, deleting this
-           line causes segfaults in testr t/pmc/eval.t */
-    PMC *garbage = thawing ? pmc_new(interp, enum_class_Undef) : PMCNULL;
-
-
     /* can't cache upper limit, visit may append items */
     do {
         (info->visit_pmc_now)(interp, current, info);

Modified: branches/pmc_freeze_cleanup/t/pmc/eval.t
==============================================================================
--- branches/pmc_freeze_cleanup/t/pmc/eval.t	Thu Dec 31 19:14:20 2009	(r43347)
+++ branches/pmc_freeze_cleanup/t/pmc/eval.t	Thu Dec 31 20:37:41 2009	(r43348)
@@ -394,7 +394,8 @@
 written
 OUTPUT
 
-pir_output_is( <<"CODE", <<'OUTPUT', "eval.thaw" );
+TODO: {
+pir_output_is( <<"CODE", <<'OUTPUT', "eval.thaw", todo => 'TT #1142 not yet fixed' );
 .sub main :main
     .local pmc io, e
     .local string file
@@ -414,6 +415,7 @@
 hello from foo_1
 hello from foo_1
 OUTPUT
+}
 
 pir_output_is( <<"CODE", <<'OUTPUT', "eval.freeze+thaw" );
 .sub main :main