[svn:parrot] r44634 - branches/rm_cflags/config/auto

[coke at svn.parrot.org]

Author: coke
Date: Thu Mar  4 21:15:26 2010
New Revision: 44634
URL: https://trac.parrot.org/parrot/changeset/44634

Log:
Don't bother to memoize -$conf changes. Fix bug where we were not actually
TESTING THE WARNING when we decided what was valid.

Must have been a thinko during one of the rewrites - happened to work for the
gcc I was using and for non-gcc. fperrad++'s failure pointed out the problem.

Modified:
   branches/rm_cflags/config/auto/warnings.pm

Modified: branches/rm_cflags/config/auto/warnings.pm
==============================================================================
--- branches/rm_cflags/config/auto/warnings.pm	Thu Mar  4 20:53:26 2010	(r44633)
+++ branches/rm_cflags/config/auto/warnings.pm	Thu Mar  4 21:15:26 2010	(r44634)
@@ -21,9 +21,6 @@
 
 use base qw(Parrot::Configure::Step);
 
-use Memoize;
-memoize('valid_warning');
-
 use Parrot::Configure::Utils ();
 use Parrot::BuildUtil;
 
@@ -320,7 +317,7 @@
 
     my $ccflags  = $conf->data->get('ccflags');
     my $warnings = join(' ', @{$self->{'validated'}});
-    my $tryflags = "$ccflags $warnings";
+    my $tryflags = "$ccflags $warnings $warning";
 
     my $command_line = Parrot::Configure::Utils::_build_compile_command( $cc, $tryflags );
     $verbose and print '  ', $command_line, "\n";
@@ -343,7 +340,7 @@
 
     $verbose and print "  output: $output\n";
 
-    if ( $output !~ /error|warning|not supported|unrecognized/i ) {
+    if ( $output !~ /error|warning|not supported/i ) {
         push @{$self->{'validated'}}, $warning;
         $verbose and print "    valid warning: '$warning'\n";
         return 1;