[svn:parrot] r44672 - in branches/ops_pct/compilers/opsc: src/Ops t

bacek at svn.parrot.org bacek at svn.parrot.org
Sat Mar 6 01:37:00 UTC 2010


Author: bacek
Date: Sat Mar  6 01:36:58 2010
New Revision: 44672
URL: https://trac.parrot.org/parrot/changeset/44672

Log:
Add test for Ops::Op.full_name

Modified:
   branches/ops_pct/compilers/opsc/src/Ops/Op.pm
   branches/ops_pct/compilers/opsc/t/04-op.t

Modified: branches/ops_pct/compilers/opsc/src/Ops/Op.pm
==============================================================================
--- branches/ops_pct/compilers/opsc/src/Ops/Op.pm	Sat Mar  6 01:35:08 2010	(r44671)
+++ branches/ops_pct/compilers/opsc/src/Ops/Op.pm	Sat Mar  6 01:36:58 2010	(r44672)
@@ -130,7 +130,10 @@
     my $name      := self.name;
     my @arg_types := self.arg_types;
 
-    say("# arg_types " ~ @arg_types);
+    # FIXME. We should always have array here.
+    @arg_types := list(@arg_types) if !pir::does__IPS(@arg_types, 'array');
+
+    say("# $name arg_types " ~ @arg_types);
     join('_', $name, |@arg_types);
 }
 

Modified: branches/ops_pct/compilers/opsc/t/04-op.t
==============================================================================
--- branches/ops_pct/compilers/opsc/t/04-op.t	Sat Mar  6 01:35:08 2010	(r44671)
+++ branches/ops_pct/compilers/opsc/t/04-op.t	Sat Mar  6 01:36:58 2010	(r44672)
@@ -5,7 +5,7 @@
 pir::load_bytecode("compilers/opsc/opsc.pbc");
 pir::load_bytecode("nqp-settings.pbc");
 
-plan(7);
+plan(8);
 
 my $op := Ops::Op.new(
     code => 42,
@@ -19,13 +19,14 @@
 ok( 1, "Op created");
 
 ok( $op.code == 42,         "... with proper code");
-ok( $op.name == 'set',      "... with proper name");
-ok( $op.type == 'inline',   "... with proper type");
+ok( $op.name eq 'set',      "... with proper name");
+ok( $op.type eq 'inline',   "... with proper type");
 ok( +$op.arg_types == 3,    "... with proper arg_types");
 say('# ' ~ $op.arg_types);
-ok( $op.body == '',         "... with empty body");
+ok( $op.body eq '',         "... with empty body");
 $op.body("SOME BODY");
-ok( $op.body == 'SOME BODY', "Op.body set");
+ok( $op.body eq 'SOME BODY', "Op.body set");
 
+ok( $op.full_name eq 'set_i_i_ic', "full_name is correct");
 
 # vim: expandtab shiftwidth=4 ft=perl6:


More information about the parrot-commits mailing list