[svn:parrot] r44783 - branches/pcc_hackathon_6Mar10/src/call

allison at svn.parrot.org allison at svn.parrot.org
Tue Mar 9 00:30:52 UTC 2010


Author: allison
Date: Tue Mar  9 00:30:51 2010
New Revision: 44783
URL: https://trac.parrot.org/parrot/changeset/44783

Log:
[pcc] Remove unused static function to set a default return value (returns now
use the same code path as args).

Modified:
   branches/pcc_hackathon_6Mar10/src/call/args.c

Modified: branches/pcc_hackathon_6Mar10/src/call/args.c
==============================================================================
--- branches/pcc_hackathon_6Mar10/src/call/args.c	Tue Mar  9 00:24:38 2010	(r44782)
+++ branches/pcc_hackathon_6Mar10/src/call/args.c	Tue Mar  9 00:30:51 2010	(r44783)
@@ -76,14 +76,6 @@
         __attribute__nonnull__(4)
         __attribute__nonnull__(5);
 
-static void assign_default_result_value(PARROT_INTERP,
-    ARGMOD(PMC *results),
-    INTVAL index,
-    INTVAL result_flags)
-        __attribute__nonnull__(1)
-        __attribute__nonnull__(2)
-        FUNC_MODIFIES(*results);
-
 PARROT_CAN_RETURN_NULL
 static PMC* clone_key_arg(PARROT_INTERP, ARGIN(PMC *key))
         __attribute__nonnull__(1)
@@ -359,9 +351,6 @@
        PARROT_ASSERT_ARG(interp) \
     , PARROT_ASSERT_ARG(arg_info) \
     , PARROT_ASSERT_ARG(accessor))
-#define ASSERT_ARGS_assign_default_result_value __attribute__unused__ int _ASSERT_ARGS_CHECK = (\
-       PARROT_ASSERT_ARG(interp) \
-    , PARROT_ASSERT_ARG(results))
 #define ASSERT_ARGS_clone_key_arg __attribute__unused__ int _ASSERT_ARGS_CHECK = (\
        PARROT_ASSERT_ARG(interp) \
     , PARROT_ASSERT_ARG(key))
@@ -1411,41 +1400,6 @@
 
 /*
 
-=item C<static void assign_default_result_value(PARROT_INTERP, PMC *results,
-INTVAL index, INTVAL result_flags)>
-
-Assign an appropriate default value to the result depending on its type
-
-=cut
-
-*/
-
-static void
-assign_default_result_value(PARROT_INTERP, ARGMOD(PMC *results), INTVAL index, INTVAL result_flags)
-{
-    ASSERT_ARGS(assign_default_result_value)
-    switch (PARROT_ARG_TYPE_MASK_MASK(result_flags)) {
-      case PARROT_ARG_INTVAL:
-        csr_fill_integer(interp, results, index, 0);
-        break;
-      case PARROT_ARG_FLOATVAL:
-        csr_fill_number(interp, results, index, 0.0);
-        break;
-      case PARROT_ARG_STRING:
-        csr_fill_string(interp, results, index, NULL);
-        break;
-      case PARROT_ARG_PMC:
-        csr_fill_pmc(interp, results, index, PMCNULL);
-        break;
-      default:
-        Parrot_ex_throw_from_c_args(interp, NULL,
-                    EXCEPTION_INVALID_OPERATION, "invalid parameter type");
-        break;
-    }
-}
-
-/*
-
 =item C<void Parrot_pcc_fill_params_from_op(PARROT_INTERP, PMC *call_object, PMC
 *raw_sig, opcode_t *raw_params)>
 


More information about the parrot-commits mailing list