[svn:parrot] r46261 - in trunk: . lib/Parrot/Pmc2c src/pmc

[coke at svn.parrot.org]

Author: coke
Date: Tue May  4 01:46:15 2010
New Revision: 46261
URL: https://trac.parrot.org/parrot/changeset/46261

Log:
make auto or manual _attrs required, closing TT #1506

Modified:
   trunk/DEPRECATED.pod
   trunk/lib/Parrot/Pmc2c/PMCEmitter.pm
   trunk/src/pmc/threadinterpreter.pmc

Modified: trunk/DEPRECATED.pod
==============================================================================
--- trunk/DEPRECATED.pod	Tue May  4 01:25:06 2010	(r46260)
+++ trunk/DEPRECATED.pod	Tue May  4 01:46:15 2010	(r46261)
@@ -113,13 +113,6 @@
 
 L<https://trac.parrot.org/parrot/ticket/1561>
 
-=item PMC must use manual_attrs or auto_attrs flag [eligible in 2.4]
-
-PMCs must no longer use default value for manual/auto attribute allocation,
-manual_attrs or auto_attrs must be specified.
-
-L<http://trac.parrot.org/parrot/ticket/1506>
-
 =item Method lower on String [eligible in 3.1]
 
 Use the downcase opcode or subclass with a method name consistent with your

Modified: trunk/lib/Parrot/Pmc2c/PMCEmitter.pm
==============================================================================
--- trunk/lib/Parrot/Pmc2c/PMCEmitter.pm	Tue May  4 01:25:06 2010	(r46260)
+++ trunk/lib/Parrot/Pmc2c/PMCEmitter.pm	Tue May  4 01:46:15 2010	(r46261)
@@ -742,7 +742,7 @@
     my $flag_manual_attrs = $self->{flags}{manual_attrs};
     die 'manual_attrs and auto_attrs can not be used together'
         if ($flag_auto_attrs && $flag_manual_attrs);
-    warn 'PMC has attributes but no auto_attrs or manual_attrs'
+    die 'PMC has attributes but no auto_attrs or manual_attrs'
         if (@{$self->attributes} && ! ($flag_auto_attrs || $flag_manual_attrs));
 
     if ( @{$self->attributes} &&  $flag_auto_attrs) {

Modified: trunk/src/pmc/threadinterpreter.pmc
==============================================================================
--- trunk/src/pmc/threadinterpreter.pmc	Tue May  4 01:25:06 2010	(r46260)
+++ trunk/src/pmc/threadinterpreter.pmc	Tue May  4 01:46:15 2010	(r46261)
@@ -49,7 +49,7 @@
 
 
 
-pmclass ThreadInterpreter extends ParrotInterpreter no_ro {
+pmclass ThreadInterpreter extends ParrotInterpreter no_ro manual_attrs {
 
 /*