[svn:parrot] r48783 - trunk/src

chromatic at svn.parrot.org chromatic at svn.parrot.org
Sat Sep 4 15:28:39 UTC 2010


Author: chromatic
Date: Sat Sep  4 15:28:39 2010
New Revision: 48783
URL: https://trac.parrot.org/parrot/changeset/48783

Log:
[src] Removed GC blocking when installing subs.

There's some risk in this patch, but blocking the GC is a big deal, and we
should use it as sparingly as possible.

Modified:
   trunk/src/namespace.c

Modified: trunk/src/namespace.c
==============================================================================
--- trunk/src/namespace.c	Sat Sep  4 15:03:54 2010	(r48782)
+++ trunk/src/namespace.c	Sat Sep  4 15:28:39 2010	(r48783)
@@ -727,9 +727,6 @@
     PMC *ns;
     Parrot_Sub_attributes *sub;
 
-    /* PF structures aren't fully constructed yet */
-    Parrot_block_GC_mark(interp);
-
     /* store relative to HLL namespace */
     PMC_get_sub(interp, sub_pmc, sub);
     Parrot_pcc_set_HLL(interp, CURRENT_CONTEXT(interp), sub->HLL_id);
@@ -762,7 +759,6 @@
 
     /* restore HLL_id */
     Parrot_pcc_set_HLL(interp, CURRENT_CONTEXT(interp), cur_id);
-    Parrot_unblock_GC_mark(interp);
 }
 
 /*


More information about the parrot-commits mailing list