[parrot/parrot] f2b304: Fix LexPad.get_iter to return an iterator of name-...

GitHub noreply at github.com
Mon May 7 01:35:38 UTC 2012


  Branch: refs/heads/master
  Home:   https://github.com/parrot/parrot
  Commit: f2b30472c61dcf6523e3bfe1770d41f969a67c1a
      https://github.com/parrot/parrot/commit/f2b30472c61dcf6523e3bfe1770d41f969a67c1a
  Author: Whiteknight <wknight8111 at gmail.com>
  Date:   2012-05-06 (Sun, 06 May 2012)

  Changed paths:
    M src/pmc/lexpad.pmc

  Log Message:
  -----------
  Fix LexPad.get_iter to return an iterator of name->value paurs in the LexPad.

Previously this was redirecting to LexInfo.get_iter, which is a name->register_index hash. Creating the new, correct, iterator requires the creation of two temporary PMCs which is not performance-friendly. This is the best we can do with the current implementation of LexInfo/LexPad. This commit fixes #575.


  Commit: 34e5ad52631aa1312a2b7694bb8016ffc7058ebd
      https://github.com/parrot/parrot/commit/34e5ad52631aa1312a2b7694bb8016ffc7058ebd
  Author: Whiteknight <wknight8111 at gmail.com>
  Date:   2012-05-06 (Sun, 06 May 2012)

  Changed paths:
    M t/pmc/lexpad.t

  Log Message:
  -----------
  Add in a test for the new LexPad.get_iter implementation.

This test code is a modified version of the test code provided by pmichaud in #575.


Compare: https://github.com/parrot/parrot/compare/55721f4...34e5ad5


More information about the parrot-commits mailing list