[parrot/parrot] 104966: [imcc] WIP attempt to fix #1039

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/parrot/parrot
  Commit: 104966bf4faaad62e0715902c348c3610a79af17
      https://github.com/parrot/parrot/commit/104966bf4faaad62e0715902c348c3610a79af17
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-02-27 (Thu, 27 Feb 2014)

  Changed paths:
    M compilers/imcc/optimizer.c
    M compilers/imcc/pbc.c

  Log Message:
  -----------
  [imcc] WIP attempt to fix #1039

but the ins->op (the op ptr) appears now later in emit_pbc


  Commit: 8272ff13fbbebe09637e4f94d93f50839c0ce717
      https://github.com/parrot/parrot/commit/8272ff13fbbebe09637e4f94d93f50839c0ce717
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-02-27 (Thu, 27 Feb 2014)

  Changed paths:
    M compilers/imcc/debug.c
    M compilers/imcc/debug.h
    M compilers/imcc/optimizer.c
    M compilers/imcc/pbc.c
    M frontend/parrot/main.c
    M frontend/parrot2/main.c
    M include/parrot/interpreter.h

  Log Message:
  -----------
  [imcc cage] move IMCC_debug_ins to debug.c, remove unused DEBUG_ defs

also do not fatalize -O2 GH 1039 empty ins->op, just warn


  Commit: 64dc724861b6fea798ffffe7271438dab35711bc
      https://github.com/parrot/parrot/commit/64dc724861b6fea798ffffe7271438dab35711bc
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-02-27 (Thu, 27 Feb 2014)

  Changed paths:
    M compilers/imcc/optimizer.c
    M compilers/imcc/pbc.c

  Log Message:
  -----------
  [imcc] Fix most -O2 errors, restore ins2->op on failed const propag.

IMCC_subst_constants may return ok with an empty ins.
Restore the old ins2->op ptr then.
If !ok also restore the symregs.
 See GH #1039

Remaining -O2 fails:
/compilers/imcc/syn/macro.t      (Wstat: 512 Tests: 42 Failed: 2)
  Failed tests:  10-11
  Non-zero exit status: 2
t/op/calling.t                    (Wstat: 512 Tests: 104 Failed: 2)
  Failed tests:  30, 36
  Non-zero exit status: 2
t/op/exit.t                       (Wstat: 256 Tests: 9 Failed: 1)
  Failed test:  6
  Non-zero exit status: 1
t/op/jitn.t                       (Wstat: 256 Tests: 14 Failed: 1)
  Failed test:  13
  Non-zero exit status: 1
t/op/lexicals.t                   (Wstat: 256 Tests: 54 Failed: 1)
  Failed test:  42
  Non-zero exit status: 1
t/pmc/io.t                        (Wstat: 1024 Tests: 35 Failed: 4)
  Failed tests:  3-4, 13-14
  Non-zero exit status: 4
t/pmc/nci.t                       (Wstat: 256 Tests: 61 Failed: 1)
  Failed test:  50
  Non-zero exit status: 1
t/pmc/os.t                        (Wstat: 512 Tests: 36 Failed: 2)
  Failed tests:  3, 5
  Non-zero exit status: 2
Files=207, Tests=7199, 72 wallclock secs ( 1.46 usr  0.49 sys + 32.52 cusr 24.70 csys = 59.17 CPU)
Result: FAIL


  Commit: ab85cac847e69b29a5f66442e6fd2f7b48756892
      https://github.com/parrot/parrot/commit/ab85cac847e69b29a5f66442e6fd2f7b48756892
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-02-27 (Thu, 27 Feb 2014)

  Changed paths:
    M compilers/imcc/optimizer.c

  Log Message:
  -----------
  [imcc] fix more -O2 errors, found but empty => delete ins

On some constant propagation on (mostly arithmetic or param) ops,
the ins can be safely deleted. GH #1039

This fixed:
t/compilers/imcc/syn/macro.t 10-11
t/pmc/io.t 13-14
t/op/lexicals.t 42

but broke: t/pmc/exception-old.t 19


  Commit: d05a883165e2ef832a3fbc71bba942ed1fc149f3
      https://github.com/parrot/parrot/commit/d05a883165e2ef832a3fbc71bba942ed1fc149f3
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-02-27 (Thu, 27 Feb 2014)

  Changed paths:
    M compilers/imcc/pbc.c

  Log Message:
  -----------
  [imcc] change emit_pbc !ins->op warnings to fatal again

closing GH #1039
all ops treated by -O2 constant propagation are now properly set


  Commit: d83514063e6d5d0fb8de494e76a8d880bfd917fd
      https://github.com/parrot/parrot/commit/d83514063e6d5d0fb8de494e76a8d880bfd917fd
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-02-27 (Thu, 27 Feb 2014)

  Changed paths:
    M ChangeLog

  Log Message:
  -----------
  ChangeLog: add GH #1039 -O2 line


Compare: https://github.com/parrot/parrot/compare/2ac3fbf6f03d...d83514063e6d