[parrot/parrot] fcba7b: [pmc2c] inline gc write barriers into vtable metho...

GitHub noreply at github.com
Thu Jun 5 20:40:42 UTC 2014


  Branch: refs/heads/rurban/pmc2c_orig2-gh1069
  Home:   https://github.com/parrot/parrot
  Commit: fcba7b1825ec2d5c1356d7243e34599c419eede5
      https://github.com/parrot/parrot/commit/fcba7b1825ec2d5c1356d7243e34599c419eede5
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M lib/Parrot/Pmc2c/Emitter.pm
    M lib/Parrot/Pmc2c/Method.pm
    M lib/Parrot/Pmc2c/PCCMETHOD.pm
    M lib/Parrot/Pmc2c/PMC.pm
    M lib/Parrot/Pmc2c/PMC/Object.pm
    M lib/Parrot/Pmc2c/Parser.pm
    M src/io/io_private.h
    M src/pmc/alarm.pmc
    M src/pmc/arrayiterator.pmc
    M src/pmc/bigint.pmc
    M src/pmc/boolean.pmc
    M src/pmc/bytebuffer.pmc
    M src/pmc/continuation.pmc
    M src/pmc/env.pmc
    M src/pmc/eventhandler.pmc
    M src/pmc/exception.pmc
    M src/pmc/exceptionhandler.pmc
    M src/pmc/fixedbooleanarray.pmc
    M src/pmc/fixedintegerarray.pmc
    M src/pmc/handle.pmc
    M src/pmc/hashiterator.pmc
    M src/pmc/hashiteratorkey.pmc
    M src/pmc/imageiofreeze.pmc
    M src/pmc/imageiosize.pmc
    M src/pmc/imageiostrings.pmc
    M src/pmc/imageiothaw.pmc
    M src/pmc/imccompiler.pmc
    M src/pmc/integer.pmc
    M src/pmc/iterator.pmc
    M src/pmc/key.pmc
    M src/pmc/lexpad.pmc
    M src/pmc/managedstruct.pmc
    M src/pmc/nativepccmethod.pmc
    M src/pmc/nci.pmc
    M src/pmc/object.pmc
    M src/pmc/opcode.pmc
    M src/pmc/oplib.pmc
    M src/pmc/packfileannotation.pmc
    M src/pmc/packfilesegment.pmc
    M src/pmc/packfileview.pmc
    M src/pmc/parrotinterpreter.pmc
    M src/pmc/parrotlibrary.pmc
    M src/pmc/pointer.pmc
    M src/pmc/ptrbuf.pmc
    M src/pmc/resizablepmcarray.pmc
    M src/pmc/scheduler.pmc
    M src/pmc/schedulermessage.pmc
    M src/pmc/sockaddr.pmc
    M src/pmc/sub.pmc
    M src/pmc/task.pmc
    M src/pmc/unmanagedstruct.pmc

  Log Message:
  -----------
  [pmc2c] inline gc write barriers into vtable methods

:no_wb detection of :manual_wb, allow RETURN(decl var) also for VTABLE methods

add_write_barrier() now calls Parrot::Pmc2c::PCCMETHOD::rewrite_RETURNS.
Also add automatic WB for 0 or 1 return statements in the method body.
Other need either a RETURN or :manual_wb or :no_wb annotations.

Set manual_wb for :no_wb and PARROT_GC_WRITE_BARRIER in --dump
Detect it now earlier, in the parser

Missing write barriers typically cause the following errors:
t/examples/shootout.t: 16 examples/shootout/regexdna.pir SEGV
t/op/gc.t
t/pmc/*.t


  Commit: 4aec117d4ccbb3eda0f3eed8d1dfba49f14e18d2
      https://github.com/parrot/parrot/commit/4aec117d4ccbb3eda0f3eed8d1dfba49f14e18d2
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/arrayiterator.pmc
    M src/pmc/capture.pmc

  Log Message:
  -----------
  [pmc] partially use new WB markers


  Commit: edb2ff0cca564246dc78be530f60537661df84c0
      https://github.com/parrot/parrot/commit/edb2ff0cca564246dc78be530f60537661df84c0
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    A .project
    M src/pmc/arrayiterator.pmc

  Log Message:
  -----------
  [pmc] GSOC start. arrayiterator :no_wb, removed unnecessary :manual_wb

Start of GSOC 2014 work. Task 1: improve GC write barriers.
See GH issue #1069


  Commit: a7cb3086794eea6e6d763db39609e92ad9896ba1
      https://github.com/parrot/parrot/commit/a7cb3086794eea6e6d763db39609e92ad9896ba1
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/callcontext.pmc

  Log Message:
  -----------
  [pmc] callcontext: manual WBs for shift_pmc & shift_string


  Commit: 40d666f8ec2bb1b933d78f157f5461a37af56368
      https://github.com/parrot/parrot/commit/40d666f8ec2bb1b933d78f157f5461a37af56368
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/key.pmc
    M src/pmc/task.pmc

  Log Message:
  -----------
  [pmc] key, task: manual WBs for shift_*, pop_*


  Commit: 66ab91d522ccabd28065f9a56bd1ba34d401517c
      https://github.com/parrot/parrot/commit/66ab91d522ccabd28065f9a56bd1ba34d401517c
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/arrayiterator.pmc
    M src/pmc/callcontext.pmc

  Log Message:
  -----------
  [pmc] callcontext :no_wb and :manual_wb


  Commit: ac5dfb8a5329ef3684a4922ea9bb004ae847fe7e
      https://github.com/parrot/parrot/commit/ac5dfb8a5329ef3684a4922ea9bb004ae847fe7e
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/key.pmc

  Log Message:
  -----------
  [pmc] key WBs


  Commit: 7635504c349427e704985e57ae234630a64dc734
      https://github.com/parrot/parrot/commit/7635504c349427e704985e57ae234630a64dc734
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/arrayiterator.pmc
    M src/pmc/callcontext.pmc
    M src/pmc/key.pmc
    M src/pmc/task.pmc

  Log Message:
  -----------
  [pmc] arrayiterator, callcontext, key, task: WBs


  Commit: dac23faf7dbb375409e6c107379635115839b90a
      https://github.com/parrot/parrot/commit/dac23faf7dbb375409e6c107379635115839b90a
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/capture.pmc
    M src/pmc/hashiterator.pmc
    M src/pmc/imageiothaw.pmc

  Log Message:
  -----------
  [pmc] capture, HashIterator, ImageIoThaw: WBs


  Commit: 8eb8f7f4b7d6c04a95ee4acba47bfcd32c3ccf5a
      https://github.com/parrot/parrot/commit/8eb8f7f4b7d6c04a95ee4acba47bfcd32c3ccf5a
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/default.pmc
    M src/pmc/object.pmc
    M src/pmc/orderedhashiterator.pmc
    M src/pmc/pmclist.pmc
    M src/pmc/resizablepmcarray.pmc

  Log Message:
  -----------
  [pmc] default, object, orderedHashIterator, pmcList, resizablePmcArray: WBs


  Commit: 5bf861b9ffae3427af6baf2f779e855bb1013048
      https://github.com/parrot/parrot/commit/5bf861b9ffae3427af6baf2f779e855bb1013048
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/callcontext.pmc
    M src/pmc/default.pmc
    M src/pmc/hashiterator.pmc
    M src/pmc/imageiothaw.pmc
    M src/pmc/object.pmc
    M src/pmc/orderedhashiterator.pmc
    M src/pmc/pmclist.pmc
    M src/pmc/resizablepmcarray.pmc

  Log Message:
  -----------
  [pmc] fix some mixed c99 declarations with generated WBs

DEBUGGED - ISO C90 forbids mixed declarations =
Solved by adding WB after declarations ; expected declaration specifiers before ‘:’ token
Solved by removing :no_wb attributes for the flagged functions


  Commit: 40de39c48d4e1a9cd3834d2a8652e44541c792cc
      https://github.com/parrot/parrot/commit/40de39c48d4e1a9cd3834d2a8652e44541c792cc
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/task.pmc

  Log Message:
  -----------
  [pmc] task: WB related errors


  Commit: 156f00ee0073648264ed9e7f959d20853315b8ff
      https://github.com/parrot/parrot/commit/156f00ee0073648264ed9e7f959d20853315b8ff
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/fixedintegerarray.pmc
    M src/pmc/fixedstringarray.pmc

  Log Message:
  -----------
  [pmc] add RETURN and WB attrs to fixedintegerarray, fixedstringarray


  Commit: 0da733e21cdcc3e24647a313e8aeb9c3f8f2dd52
      https://github.com/parrot/parrot/commit/0da733e21cdcc3e24647a313e8aeb9c3f8f2dd52
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/callcontext.pmc

  Log Message:
  -----------
  [pmc] re-add some WBs to callcontext


  Commit: 2675ea8627f8fd104b5f71cd81546f940878cd05
      https://github.com/parrot/parrot/commit/2675ea8627f8fd104b5f71cd81546f940878cd05
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/class.pmc
    M src/pmc/imccompiler.pmc
    M src/pmc/key.pmc
    M src/pmc/namespace.pmc
    M src/pmc/nci.pmc
    M src/pmc/opcode.pmc
    M src/pmc/packfileview.pmc
    M src/pmc/parrotlibrary.pmc
    M src/pmc/sockaddr.pmc
    M src/pmc/socket.pmc
    M src/pmc/timer.pmc

  Log Message:
  -----------
  [pmc] fix wrong C99 UNUSED macros and add a few :no_wb

class,imccompiler,key,namespace,nci,opcode,packfileview,parrotlibrary,
sockaddr,socket,timer


  Commit: 8892fe51f7947a565d58876527b5aabde37054de
      https://github.com/parrot/parrot/commit/8892fe51f7947a565d58876527b5aabde37054de
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/arrayiterator.pmc
    M src/pmc/callcontext.pmc
    M src/pmc/continuation.pmc
    M src/pmc/filehandle.pmc
    M src/pmc/fixedstringarray.pmc
    M src/pmc/imageiothaw.pmc
    M src/pmc/integer.pmc
    M src/pmc/key.pmc
    M src/pmc/object.pmc
    M src/pmc/packfileview.pmc
    M src/pmc/resizablepmcarray.pmc
    M src/pmc/task.pmc

  Log Message:
  -----------
  [pmc] fix wrong WB annotations

and add needed manual WBs


  Commit: c2335619694b5dfd66d4d20ace7e2889b671deff
      https://github.com/parrot/parrot/commit/c2335619694b5dfd66d4d20ace7e2889b671deff
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M lib/Parrot/Pmc2c/Method.pm

  Log Message:
  -----------
  [pmc2c] Method::decl fix Possibly forgotten UNUSED warning

for the WB rewrite.


  Commit: 3316a5117311c93d2de6acbce79dec13ce8410f2
      https://github.com/parrot/parrot/commit/3316a5117311c93d2de6acbce79dec13ce8410f2
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M lib/Parrot/Pmc2c/PCCMETHOD.pm

  Log Message:
  -----------
  [pmc2c] support RETURN(PMC* const ...) and (INTVAL pos>>32)

const is no variable name.
allow full expressions as return value, not just names.

just skip ptr dereferences /^\**/. Note that the * return syntax is flawed,
as we should support both cases, return *ptr; and return ptr;
But we get away with it as we return only return (decl)*ptr and return (decl*)ptr;


  Commit: effd74855b0ba50b8facb8bb412b33fc987ca489
      https://github.com/parrot/parrot/commit/effd74855b0ba50b8facb8bb412b33fc987ca489
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M t/pmc/fixedstringarray.t

  Log Message:
  -----------
  [test] move test_gc to the end of t/pmc/fixedstringarray.t

all other tests pass fine, even with wrong write barriers


  Commit: 423bbbd253c8ec75640080b2caa59d892590efad
      https://github.com/parrot/parrot/commit/423bbbd253c8ec75640080b2caa59d892590efad
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M MANIFEST
    A tools/dev/vgp_old

  Log Message:
  -----------
  [tools] add tools/dev/vgp_old using parrot_old

building parrot_old is much faster than parrot, when tracing leaks


  Commit: a053a4b42ed9b1bd97c9c34a068553c5fe17acc1
      https://github.com/parrot/parrot/commit/a053a4b42ed9b1bd97c9c34a068553c5fe17acc1
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/gc/system.c

  Log Message:
  -----------
  [gc] simplify the stack scanning loop

just inc the stack ptr
reverse the hi <=> lo markers to make sense
comment the unsafe ptr dereference here, where asan and valgrind do complain.


  Commit: 982aba75fcb99ca1d7c0ae12a45a256a1e4467b6
      https://github.com/parrot/parrot/commit/982aba75fcb99ca1d7c0ae12a45a256a1e4467b6
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/task.pmc

  Log Message:
  -----------
  Revert "[pmc] task: WB related errors"

This reverts commit ab201b1657795217c95c7f62c8f1bf71418687b0.


  Commit: 7d7f821f928826c08127c110e4b10cc3aac74025
      https://github.com/parrot/parrot/commit/7d7f821f928826c08127c110e4b10cc3aac74025
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/addrregistry.pmc
    M src/pmc/alarm.pmc
    M src/pmc/arrayiterator.pmc
    M src/pmc/bigint.pmc
    M src/pmc/bignum.pmc
    M src/pmc/boolean.pmc
    M src/pmc/bytebuffer.pmc
    M src/pmc/callback.pmc
    M src/pmc/callcontext.pmc
    M src/pmc/capture.pmc
    M src/pmc/class.pmc
    M src/pmc/complex.pmc
    M src/pmc/continuation.pmc
    M src/pmc/coroutine.pmc
    M src/pmc/default.pmc
    M src/pmc/env.pmc
    M src/pmc/eventhandler.pmc
    M src/pmc/exception.pmc
    M src/pmc/exceptionhandler.pmc
    M src/pmc/exporter.pmc
    M src/pmc/filehandle.pmc
    M src/pmc/fixedbooleanarray.pmc
    M src/pmc/fixedfloatarray.pmc
    M src/pmc/fixedintegerarray.pmc
    M src/pmc/fixedpmcarray.pmc
    M src/pmc/fixedstringarray.pmc
    M src/pmc/float.pmc
    M src/pmc/hash.pmc
    M src/pmc/hashiterator.pmc
    M src/pmc/hashiteratorkey.pmc
    M src/pmc/imageiofreeze.pmc
    M src/pmc/imageiosize.pmc
    M src/pmc/imageiostrings.pmc
    M src/pmc/imageiothaw.pmc
    M src/pmc/imccompiler.pmc
    M src/pmc/integer.pmc
    M src/pmc/iterator.pmc
    M src/pmc/key.pmc
    M src/pmc/lexinfo.pmc
    M src/pmc/lexpad.pmc
    M src/pmc/mappedbytearray.pmc
    M src/pmc/multisub.pmc
    M src/pmc/namespace.pmc
    M src/pmc/nativepccmethod.pmc
    M src/pmc/nci.pmc
    M src/pmc/null.pmc
    M src/pmc/object.pmc
    M src/pmc/oplib.pmc
    M src/pmc/orderedhash.pmc
    M src/pmc/orderedhashiterator.pmc
    M src/pmc/packfile.pmc
    M src/pmc/packfileannotation.pmc
    M src/pmc/packfileannotations.pmc
    M src/pmc/packfilebytecodesegment.pmc
    M src/pmc/packfileconstanttable.pmc
    M src/pmc/packfiledebug.pmc
    M src/pmc/packfiledirectory.pmc
    M src/pmc/packfileopmap.pmc
    M src/pmc/packfilerawsegment.pmc
    M src/pmc/packfilesegment.pmc
    M src/pmc/packfileview.pmc
    M src/pmc/parrotinterpreter.pmc
    M src/pmc/parrotlibrary.pmc
    M src/pmc/pmclist.pmc
    M src/pmc/pmcproxy.pmc
    M src/pmc/pointer.pmc
    M src/pmc/proxy.pmc
    M src/pmc/ptr.pmc
    M src/pmc/ptrbuf.pmc
    M src/pmc/ptrobj.pmc
    M src/pmc/resizablebooleanarray.pmc
    M src/pmc/resizablepmcarray.pmc
    M src/pmc/role.pmc
    M src/pmc/scalar.pmc
    M src/pmc/scheduler.pmc
    M src/pmc/schedulermessage.pmc
    M src/pmc/socket.pmc
    M src/pmc/string.pmc
    M src/pmc/stringbuilder.pmc
    M src/pmc/stringhandle.pmc
    M src/pmc/stringiterator.pmc
    M src/pmc/structview.pmc
    M src/pmc/sub.pmc
    M src/pmc/task.pmc
    M src/pmc/timer.pmc
    M src/pmc/undef.pmc
    M src/pmc/unmanagedstruct.pmc
    M src/vtable.tbl

  Log Message:
  -----------
  [pmc] Fixup most WBs. :no_wb for all non-writers, ... [1/2]

:manual_wb on VTABLE method calls on SELF which to a WB (avoid duplicates).
See new description at https://github.com/parrot/parrot/issues/1069


  Commit: 8f3e752723f0c2a21612aa5ba8a532c300a770ac
      https://github.com/parrot/parrot/commit/8f3e752723f0c2a21612aa5ba8a532c300a770ac
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/bignum.pmc
    M src/pmc/boolean.pmc
    M src/pmc/handle.pmc
    M src/pmc/hashiteratorkey.pmc
    M src/pmc/imageiofreeze.pmc
    M src/pmc/imageiosize.pmc
    M src/pmc/imageiostrings.pmc
    M src/pmc/key.pmc
    M src/pmc/lexpad.pmc
    M src/pmc/managedstruct.pmc
    M src/pmc/mappedbytearray.pmc
    M src/pmc/namespace.pmc
    M src/pmc/opcode.pmc
    M src/pmc/oplib.pmc
    M src/pmc/packfile.pmc
    M src/pmc/packfileannotation.pmc
    M src/pmc/packfileannotations.pmc
    M src/pmc/packfilebytecodesegment.pmc
    M src/pmc/packfileconstanttable.pmc
    M src/pmc/packfiledebug.pmc
    M src/pmc/packfiledirectory.pmc
    M src/pmc/packfileopmap.pmc
    M src/pmc/packfilerawsegment.pmc
    M src/pmc/packfilesegment.pmc
    M src/pmc/packfileview.pmc
    M src/pmc/parrotlibrary.pmc
    M src/pmc/pointer.pmc
    M src/pmc/proxy.pmc
    M src/pmc/ptr.pmc
    M src/pmc/ptrobj.pmc
    M src/pmc/resizablebooleanarray.pmc
    M src/pmc/resizablefloatarray.pmc
    M src/pmc/resizableintegerarray.pmc
    M src/pmc/resizablestringarray.pmc
    M src/pmc/sockaddr.pmc
    M src/pmc/socket.pmc
    M src/pmc/stringhandle.pmc
    M src/pmc/stringiterator.pmc
    M src/pmc/structview.pmc
    M src/pmc/undef.pmc
    M src/pmc/unmanagedstruct.pmc

  Log Message:
  -----------
  [pmc] Fixup most WBs [2/2]

:no_wb on non-writers, :manual_wb on VTABLE method calls on SELF which to a WB (avoid duplicates).
See new description at https://github.com/parrot/parrot/issues/1069
Some UNUSED missing.

Still the same 2 regressions:
t/op/gc.t                                 (Wstat: 11 Tests: 19 Failed: 0)
  Non-zero wait status: 11
  Parse errors: No plan found in TAP output
t/pmc/namespace-old.t                     (Wstat: 1024 Tests: 38 Failed: 4)
  Failed tests:  27-30
  Non-zero exit status: 4


  Commit: 22c1ed3f49b43d708d428b464768f11d21a6c8d9
      https://github.com/parrot/parrot/commit/22c1ed3f49b43d708d428b464768f11d21a6c8d9
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/bigint.pmc
    M src/pmc/env.pmc
    M src/pmc/handle.pmc
    M src/pmc/imageiosize.pmc
    M src/pmc/imccompiler.pmc
    M src/pmc/iterator.pmc
    M src/pmc/lexpad.pmc
    M src/pmc/parrotlibrary.pmc
    M src/pmc/task.pmc
    M src/pmc/unmanagedstruct.pmc

  Log Message:
  -----------
  [pmc] add more UNUSED for :no_wb methods

also remove a wrong task WB


  Commit: 7c8f0c4728caccf8bd16072f442d5f38c6b61fbe
      https://github.com/parrot/parrot/commit/7c8f0c4728caccf8bd16072f442d5f38c6b61fbe
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/class.pmc

  Log Message:
  -----------
  [pmc] fix class WBs, detected by ZYROz

isa_pmc, freeze have a manual WBs
thawfinish, remove_attribute indirectly via build_attrib_index
name needs one for the write case


  Commit: 43947ff98aa793827477565676fc1dc53f97fb89
      https://github.com/parrot/parrot/commit/43947ff98aa793827477565676fc1dc53f97fb89
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M lib/Parrot/Pmc2c/PCCMETHOD.pm

  Log Message:
  -----------
  [pmc2c] fix del_namespace. require {} around WB return

there exist many methods without proper {} blocks for RETURN().

grep -B1 "RETURN(" src/pmc/*.pmc|grep -A1 "if "|grep -v "{"
such as:
src/pmc/namespace.pmc-        if (PMC_IS_NULL(ns))
src/pmc/namespace.pmc:            RETURN(void);


  Commit: b35882d53000d0cd06b266f311b1564edc2bd2ee
      https://github.com/parrot/parrot/commit/b35882d53000d0cd06b266f311b1564edc2bd2ee
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/default.pmc
    M src/pmc/hashiterator.pmc
    M src/pmc/imageiothaw.pmc
    M src/pmc/key.pmc
    M src/pmc/object.pmc
    M src/pmc/pmclist.pmc
    M src/pmc/resizablepmcarray.pmc

  Log Message:
  -----------
  [codingstd] fix trailing whitespace

and remove one too much WB in pmclist.shift_pmc


  Commit: 67a071ecbb503ef183579c93fd6ca8af8050ce7e
      https://github.com/parrot/parrot/commit/67a071ecbb503ef183579c93fd6ca8af8050ce7e
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    R .project
    M src/pmc/addrregistry.pmc
    M src/pmc/arrayiterator.pmc
    M src/pmc/bigint.pmc
    M src/pmc/bignum.pmc
    M src/pmc/boolean.pmc
    M src/pmc/bytebuffer.pmc
    M src/pmc/capture.pmc
    M src/pmc/class.pmc
    M src/pmc/complex.pmc
    M src/pmc/default.pmc
    M src/pmc/env.pmc
    M src/pmc/filehandle.pmc
    M src/pmc/fixedbooleanarray.pmc
    M src/pmc/fixedfloatarray.pmc
    M src/pmc/fixedintegerarray.pmc
    M src/pmc/fixedpmcarray.pmc
    M src/pmc/fixedstringarray.pmc

  Log Message:
  -----------
  [pmc] Changed WB annotations a*-f*.pmc

A 2nd eye-pair sees more.


  Commit: dba8e6be876e22aeb52059d84bafb0b05afb7c1b
      https://github.com/parrot/parrot/commit/dba8e6be876e22aeb52059d84bafb0b05afb7c1b
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/fixedpmcarray.pmc
    M src/pmc/handle.pmc
    M src/pmc/hash.pmc
    M src/pmc/imageiofreeze.pmc
    M src/pmc/imageiosize.pmc
    M src/pmc/imageiostrings.pmc
    M src/pmc/imageiothaw.pmc
    M src/pmc/imccompiler.pmc
    M src/pmc/integer.pmc
    M src/pmc/iterator.pmc
    M src/vtable.tbl

  Log Message:
  -----------
  [pmc] Changed WB annotations - [f-i]*.pmc


  Commit: f5a24a8bdee545d349def415b2af2fd8e92c937f
      https://github.com/parrot/parrot/commit/f5a24a8bdee545d349def415b2af2fd8e92c937f
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/key.pmc
    M src/pmc/lexpad.pmc
    M src/pmc/mappedbytearray.pmc
    M src/pmc/namespace.pmc
    M src/pmc/nci.pmc
    M src/pmc/null.pmc
    M src/pmc/object.pmc
    M src/pmc/opcode.pmc
    M src/pmc/oplib.pmc
    M src/pmc/orderedhash.pmc
    M src/pmc/orderedhashiterator.pmc

  Log Message:
  -----------
  [pmc] Improved WB annotations - [j-o]*.pmc


  Commit: a6fabb86ea6dba90a755eb4da545300f9a621cd1
      https://github.com/parrot/parrot/commit/a6fabb86ea6dba90a755eb4da545300f9a621cd1
  Author: ZYROz <ZYROz at users.noreply.github.com>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/packfileannotations.pmc
    M src/pmc/packfilebytecodesegment.pmc
    M src/pmc/packfileconstanttable.pmc
    M src/pmc/packfiledirectory.pmc
    M src/pmc/packfilerawsegment.pmc
    M src/pmc/packfilesegment.pmc
    M src/pmc/packfileview.pmc
    M src/pmc/parrotinterpreter.pmc
    M src/pmc/parrotlibrary.pmc
    M src/pmc/pmclist.pmc
    M src/pmc/ptr.pmc
    M src/pmc/ptrobj.pmc

  Log Message:
  -----------
  [pmc] Improved WB annotations - p*.pmc


  Commit: a0c3ef77464a1550aaaaaf2db46699c41d2e39fa
      https://github.com/parrot/parrot/commit/a0c3ef77464a1550aaaaaf2db46699c41d2e39fa
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/env.pmc

  Log Message:
  -----------
  [pmc] env whitespace

fix trailing space in env.pmc


  Commit: bcceaa929434616d54d0af3945bc6db7f4843eba
      https://github.com/parrot/parrot/commit/bcceaa929434616d54d0af3945bc6db7f4843eba
  Author: Reini Urban <rurban at cpanel.net>
  Date:   2014-06-05 (Thu, 05 Jun 2014)

  Changed paths:
    M src/pmc/class.pmc
    M src/pmc/object.pmc

  Log Message:
  -----------
  [pmc] Change WBs for Class.instantiate, Object.morph


Compare: https://github.com/parrot/parrot/compare/b2bf96ce6f94...bcceaa929434


More information about the parrot-commits mailing list