[perl #46149] [TODO] Parrot_runcode and/or imcc_run_pbc should return a value

Andrew Whitworth via RT parrotbug-followup at parrotcode.org
Mon Dec 15 15:21:14 UTC 2008


On Sat Oct 06 03:16:45 2007, pcoch wrote:
> In compilers/imcc/main.c:imcc_run_pbc() there is the todo item:
> 
> /* XXX no return value :-( */
> Parrot_runcode(interp, argc, argv);

This request is a little cryptic. imcc_run_pbc() calls Parrot_runcode,
which also is a void return type. Parrot_runcode in turn calls
Parrot_runops_fromc_args, which returns a PMC*. Should we propagate the
PMC* return value from Parrot_runops_fromc_args all the way up to
imcc_run_pbc and return that, or should we coerce that value into a
boolean type and return that?

Or, should we determine the success or failure of the function and
return that status value?

It will be easy enough to add a return value to this function(s) if we
know what we want to be returning.

-- 
Andrew Whitworth
a.k.a Whiteknight




More information about the parrot-dev mailing list