Release tomorrow

[Andy Dougherty]

On Mon, 15 Dec 2008, Andrew Whitworth wrote:

> I hate to be a nagging Nelly, but I wanted to send out one more
> reminder about the release tomorrow:

> 1) Any more NEWS, PLATFORMS, CREDITS, or other updates that need to be
> made before the release? Get the updates in ASAP!

I'm afraid today's attempt to build on Solaris failed again (patches 
below), so no PLATFORMS updates this month from me :-(.

> 5) Are there any other issues that need to be dealt with that don't
> have an associated Trac or RT ticket?

Yes -- I posted a trivial patch to un-inline src/string.c:string_free().
That still needs to be applied.  Should I open a Trac ticket for 
it?  I thought it was so obvious and easy a fix that more time would be 
wasted opening and closing a ticket than simply applying the fix.

I also encountered two trivial fixes today that I needed.  I've appended 
the patch below.  (put CONST_STRING stuff all on one line, and avoid 
'//'-style comments.)  Should I open Trac ticket for this?

--- src/exceptions.c.old	2008-12-15 10:14:17.000000000 -0500
+++ src/exceptions.c	2008-12-15 10:13:56.000000000 -0500
@@ -195,8 +195,7 @@
         STRING * const message     = VTABLE_get_string(interp, exception);
         const INTVAL   severity    = VTABLE_get_integer_keyed_str(interp, exception, CONST_STRING(interp, "severity"));
         if (severity < EXCEPT_error) {
-            PMC *resume = VTABLE_get_attr_str(interp, exception,
-                    CONST_STRING(interp, "resume"));
+            PMC *resume = VTABLE_get_attr_str(interp, exception, CONST_STRING(interp, "resume"));
             if (string_equal(interp, message, CONST_STRING(interp, "")) == 1) {
                 Parrot_io_eprintf(interp, "%S\n", message);
             }
@@ -206,7 +205,7 @@
 
             /* caution against output swap (with PDB_backtrace) */
             fflush(stderr);
-            //PDB_backtrace(interp);
+            /* PDB_backtrace(interp); */
 
             if (!PMC_IS_NULL(resume)) {
                 return VTABLE_invoke(interp, resume, NULL);

-- 
    Andy Dougherty		doughera at lafayette.edu