Release tomorrow

[Will Coleda]

On Mon, Dec 15, 2008 at 12:12 PM, Andy Dougherty <doughera at lafayette.edu> wrote:
> On Mon, 15 Dec 2008, Andrew Whitworth wrote:
>
>> I hate to be a nagging Nelly, but I wanted to send out one more
>> reminder about the release tomorrow:
>
>> 1) Any more NEWS, PLATFORMS, CREDITS, or other updates that need to be
>> made before the release? Get the updates in ASAP!
>
> I'm afraid today's attempt to build on Solaris failed again (patches
> below), so no PLATFORMS updates this month from me :-(.

:(

>> 5) Are there any other issues that need to be dealt with that don't
>> have an associated Trac or RT ticket?
>
> Yes -- I posted a trivial patch to un-inline src/string.c:string_free().
> That still needs to be applied.  Should I open a Trac ticket for
> it?  I thought it was so obvious and easy a fix that more time would be
> wasted opening and closing a ticket than simply applying the fix.

The problem with patches going elsewhere is that they can, as you
note, get lost. Perhaps we should investigate a stricter codingstd
policy in the week pre-release, or split up any codingstd tests that
are actually build breakers on certain platforms into a strict subset
we can run by default. (Running the whole suite is overkill. Running
the C++ comments is not.)

> I also encountered two trivial fixes today that I needed.  I've appended
> the patch below.  (put CONST_STRING stuff all on one line, and avoid
> '//'-style comments.)  Should I open Trac ticket for this?

Looks like this one was fixed in:

r33920 | infinoid | 2008-12-15 11:44:54 -0500 (Mon, 15 Dec 2008) | 4 lines

-- 
Will "Coke" Coleda