second string refactor landed
Patrick R. Michaud
pmichaud at pobox.com
Tue Feb 3 18:12:29 UTC 2009
On Tue, Feb 03, 2009 at 11:39:32AM -0600, Patrick R. Michaud wrote:
> On Tue, Feb 03, 2009 at 12:31:17AM -0800, Allison Randal wrote:
> > I merged in the second half of the string refactors in r36319, an API
> > function renaming to match the Parrot coding standards and the
> > specification in PDD 28.
>
> Can we PLEASE PLEASE PLEASE use this as an opportunity to
> fix the naming and/or semantics of string_equal
> (now Parrot_str_equal)?
>
> Previously the C<string_equal> function (and now C<Parrot_str_equal> )
> returns zero (i.e., false) if the two arguments are *NOT* equal,
> which makes for some very confusing code. Let's not propagate or
> sanctify this any further than it already exists.
Andrew correctly points out that I mis-wrote here. The above
should read:
Previously the C<string_equal> function (and now
C<Parrot_str_equal> ) > returns zero (i.e., false) if the
two arguments are equal, and non-zero if they are not equal.
This makes for some very confusing code. Let's not propagate or
sanctify this any further than it already exists.
Pm
More information about the parrot-dev
mailing list