[PATCH] Re: [Parrot] #294: [PATCH] Pick correct format for Configure.pl --floatval='long double'

[Andrew Dougherty]

> #294: [PATCH] Pick correct format for Configure.pl --floatval='long double'
> -----------------------+----------------------------------------------------
>  Reporter:  doughera   |        Owner:        
>      Type:  patch      |       Status:  closed
>  Priority:  normal     |    Milestone:        
> Component:  configure  |      Version:        
>  Severity:  medium     |   Resolution:  fixed 
>  Keywords:             |         Lang:        
>     Patch:  applied    |     Platform:        
> -----------------------+----------------------------------------------------
> Changes (by Infinoid):
> 
>   * status:  new => closed
>   * resolution:  => fixed
>   * patch:  => applied
> 
> 
> Comment:
> 
>  Thanks, applied in r36495.

Thanks for applying that.  I have one additional fix-up right away.  It 
turns out that this will cause a failure in one of the post-configure 
tests.  The problem is that the test is hard-coded to look for the wrong 
answer.  I propose just deleting the test.  (Alternatively, one could copy 
and paste the code to look for the correct answer from the config step, 
but I don't know what that would actually end up testing, other than one's 
ability to copy and paste correctly.)

Sorry for missing this before.  I usually skip the config tests and just 
run 'make coretest'.

[I've replied to the parrot-tickets list, but I don't know if that 
actually works.  (I guess I'll find out.)]

--- parrot-current/steps/auto_format-01.t
+++ parrot-andy/t/steps/auto_format-01.t
@@ -5,7 +5,7 @@
 
 use strict;
 use warnings;
-use Test::More tests => 16;
+use Test::More tests => 15;
 use Carp;
 use lib qw( lib t/configure/testlib );
 use_ok('config::auto::format');
@@ -99,8 +99,6 @@
 {
     $conf->data->set( nv => 'long double' );
     auto::format::_set_floatvalfmt_nvsize($conf);
-    is($conf->data->get( 'floatvalfmt' ), '%Lf',
-        "floatvalfmt set as expected");
     is($conf->data->get( 'nvsize' ), $conf->data->get( 'hugefloatvalsize' ),
         "nvsize set as expected");
     $conf->data->set(

-- 
    Andy Dougherty		doughera at lafayette.edu