[perl #62010] [PATCH] fix PARROT_EXPORT visibility=default for gcc other than 4.x

[James Keenan via RT]

On Tue Jan 06 04:33:31 2009, donaldhunter wrote:
> This patch fixes a problem with gcc 3.4.6 on Linux where
-fvisibility=hidden
> is detected as supported but __attribute__((visibility("default"))) is not
> used for PARROT_EXPORT. The setting for export visibility was
hard-coded for
> gcc > 4.0 so I changed it to be a new test based on the detection of
support
> for -fvisibility=hidden
> 
> I created a new file for the config step because it has to happen after
> config/auto/warnings.pm and there's no other relevant file to put it in.
> 
>  config/auto/export.pm             |   55
> ++++++++++++++++++++++++++++++++++++++
>  config/auto/gcc.pm                |    3 --
>  lib/Parrot/Configure/Step/List.pm |    1
>  3 files changed, 56 insertions(+), 3 deletions(-)


Donald,

While I thank you for your contribution, I would be very strongly
opposed to adding a new Parrot configuration step for such a small
correction.

1.  Among other things, we would have to add an additional file,
t/steps/auto_export-01.t, to test the code.

2.  Do you know whether this bug afflicts more recent versions of gcc?

Could we get some feedback from some of our C-compiler experts on this?

Thank you very much.
kid51