Comparison of encoding with encoding _number_ in r48994

Nick Wellnhofer wellnhofer at aevum.de
Tue Sep 14 12:01:03 UTC 2010


On 14/09/2010 11:15, Lithos wrote:
> Hi!
>
> It looks like after this change in r48994
>
> -    if (size || (!STRING_IS_NULL(s)&&  s->encoding !=
> CONST_STRING(interp, "")->encoding))
> +    if (size || (encoding != CONST_STRING(interp, "")->encoding->num))
>
> the code is now comparing a const STR_VTABLE * to an int (encoding->num).
> Seems wrong to me.

Fixed in r48997. Thanks for the report.

Nick


More information about the parrot-dev mailing list