src/platform/generic/dl.c: codingstd failure not easily fixed

Andy Lester andy at petdance.com
Tue Apr 3 02:42:59 UTC 2012


> And, indeed, these two additions cleared up 2 of the 3 failures in c_arg_assert.t.  But when I tried the same thing on push_handle_entry(), I get horrible test errors such as this:

push_handle_entry()'s arg was defined as ARGIN(), which makes the ASSERT_ARGS fail if you pass NULL to it.  So it needs to be set as ARGIN_NULLOK().

I'm making that change and running tests, and will commit.


> And, while you're at it, could you write documentation for these three functions?  (If there had been some documentation, I might have had more of a clue as to what to do with the assert.)


I can't document them.  I was just adding the headerizer code so the assertions would work.

xoxo,
Andy

--
Andy Lester => andy at petdance.com => www.petdance.com => AIM:petdance



More information about the parrot-dev mailing list