Build failure on NetBSD at RELEASE_4_5_0-16-g5cba8ae

Andy Dougherty doughera at lafayette.edu
Fri Aug 3 18:26:51 UTC 2012


On Wed, 18 Jul 2012, Andy Dougherty wrote:

> On Tue, 17 Jul 2012, Jonathan "Duke" Leto wrote:
> 
> > Howdy,
> > 
> > It looks like Parrot_get_cpu_type is only defined in
> > src/platform/generic/misc.c and src/platform/win32/misc.c but not
> > src/platform/netbsd/misc.c .
> > 
> > Not sure if that is the issue, but it seems likely.
> 
> Yes, that would explain it.  The "correct" way to have done it, within 
> parrot's src/platform hierarchy, would have been to make two new files, 
> something like generic/cpu_type.c and win32/cpu_type.c, along with the 
> appropriate tweaks to MANIFEST and the root Makefile.  Then no special 
> NetBSD tweaks would be needed.

The attached patch implements this.  I tested it on Linux and NetBSD.  I 
have not tested it on Windows.

-- 
    Andy Dougherty		doughera at lafayette.edu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Move-Parrot_cpu_type-function-out-of-src-platform-mi.patch
Type: text/x-diff
Size: 10068 bytes
Desc: 
URL: <http://lists.parrot.org/pipermail/parrot-dev/attachments/20120803/1bd84662/attachment.bin>


More information about the parrot-dev mailing list