threads branch: What is purpose of lib/Parrot/Pmc2c/PMC/Proxy.pm?

[Andrew Whitworth]

I think, and my memory may need refreshing, that file was removed from
master within the past few months as part of other refactors and
reformulations. I think what we need to do is look back over the logs
in master and see when that file was removed and why it didn't also
disappear in any recent merges from master. I suspect nine may have
modified that file, and I wasn't able to map his changes to the new
code in master when I merged that code.

I will try to hunt around and try to match up where the new code has
been moved to tonight when I get home.

--Andrew Whitworth


On Sat, Aug 11, 2012 at 8:48 PM, James E Keenan <jkeen at verizon.net> wrote:
> In the threads branch, I see that there exists a file which does not (or,
> perhaps, no longer) exist in master: lib/Parrot/Pmc2c/PMC/Proxy.pm.
> Parrot::Pmc2c::PMC::Proxy inherits from Parrot::Pmc2c::PMC.  It provides
> only one public method, pre_method_gen(), which presumably overrides
> Parrot::Pmc2c::PMC::pre_method_gen() whenever Parrot::Pmc2c::PMC::Proxy is
> 'use'd.
>
> However, AFAICT, Parrot::Pmc2c::PMC::Proxy is only imported into one other
> package:
>
> $ ack 'use Parrot::Pmc2c::PMC::Proxy' lib/
> lib/Parrot/Pmc2c/Pmc2cMain.pm
> 20:use Parrot::Pmc2c::PMC::Proxy ();
>
> But Pmc2cMain never invokes pre_method_gen().  Hence, nothing from
> lib/Parrot/Pmc2c/PMC/Proxy.pm appears to be used anywhere -- implying that
> it can and should be deleted.
>
> Can anyone explain what lib/Parrot/Pmc2c/PMC/Proxy.pm does?
>
> Thank you very much.
> Jim Keenan
>
>
>
> _______________________________________________
> http://lists.parrot.org/mailman/listinfo/parrot-dev