[PATCH] Possible threads race condition in src/alarm.c

Andrew Whitworth wknight8111 at gmail.com
Wed Aug 29 23:00:17 UTC 2012


On Wed, Aug 29, 2012 at 4:50 PM, Reini Urban <rurban at x-ray.at> wrote:
> I verified that it fixes the sleep deadlock, but with
> the deadlock fix there come 3 more races detected by tsan.
> (See http://blogs.perl.org/users/rurban/2012/08/threadsanitizer.html)
>
> Before:
> $ tsan --announce-threads ./parrot t/pmc/task.t
> 1..6
> ok 1 - initialized
> ok 2 task1 ran
> ok 3 task2 ran
> ok 4 sub1 ran
> .. Deadlock in sleep cond_wait.
>
> After:
> ...

Do those deadlocks cause any test failures? Are they serious concerns?
I think we're getting pretty darn close to 100% here, I don't want to
rush a merge until we're ready.

I'm away for the weekend. I suggest we don't attempt any merge until
next week at the earliest, if we think we've gotten the issues ironed
out by then. Come Tuesday or Wednesday if things are looking good I
would definitely like to start pushing forward.

--Andrew Whitworth


More information about the parrot-dev mailing list