More IO Changes (need feedback)

[Andrew Whitworth]

Thanks for the tests, Jim. Yes, some failures are known and even
expected. I don't want to start cleanup and details work until I get
the go-ahead. I don't want to waste time on it if it's not the
direction we want to go.

--Andrew Whitworth


On Wed, Nov 21, 2012 at 6:35 PM, James E Keenan <jkeen at verizon.net> wrote:
> On 11/18/12 6:43 PM, Andrew Whitworth wrote:
>>
>> I've got three new branches that I've been playing with today to make
>> even more changes to the IO system. I'd like some feedback on these
>> changes before I do any more work on these. I haven't spent much time
>> on these yet, so if people don't like what they're doing I can abandon
>> ship without losing too much effort.
>
>
> Good to see the torrent of whiteknight branches resuming!
>
> Here are results I got today attempting to build or test these branches.
>>
>>
>> 1) whiteknight/pipe_pmc
>
>
> src/pmc/pipe.pmc; t/pmc/pipe.t: Advance copyright date to 2012 (or, perhaps,
> since new files, just to 2012).
>
> make fulltest:
>
> $ perl t/distro/manifest_generated.t
> 1..5
> ok 1 - MANIFEST.generated exists
> ok 2 - MANIFEST.generated is sorted
> ok 3 - MANIFEST.generated contains no irregular records
> not ok 4 - MANIFEST.generated lists all core PMC headers
> #   Failed test 'MANIFEST.generated lists all core PMC headers'
> #   at t/distro/manifest_generated.t line 48.
> #     Structures begin differing at:
> #          $got->[0] = Does not exist
> #     $expected->[0] = 'include/pmc/pmc_pipe.h'
> not ok 5 - MANIFEST.generated lists all core PMC dump files
> #   Failed test 'MANIFEST.generated lists all core PMC dump files'
> #   at t/distro/manifest_generated.t line 52.
> #     Structures begin differing at:
> #          $got->[0] = Does not exist
> #     $expected->[0] = 'src/pmc/pipe.dump'
> # Looks like you failed 2 tests of 5.
>
>
>
>> 2) whiteknight/io_vtable_lookup
>
>
> Build failures on both Darwin/x86_64 and Linux/i386.  Excerpts from 'tail'
> of 'make' output on Linux:
>
> src/pmc/pipe.c: In function 'Parrot_Pipe_mark':
> src/pmc/pipe.c:178: error: 'Parrot_Pipe_attributes' has no member named
> 'read_buffer'
> src/pmc/pipe.c:179: error: 'Parrot_Pipe_attributes' has no member named
> 'write_buffer'
> src/pmc/pipe.c: In function 'Parrot_Pipe_init_orig':
> src/pmc/pipe.c:931: warning: cast discards qualifiers from pointer target
> typesrc/pmc/pipe.c:935: error: 'Parrot_Pipe_attributes' has no member named
> 'read_buffer'src/pmc/pipe.c:936: error: 'Parrot_Pipe_attributes' has no
> member named 'write_buffer'make: *** [src/pmc/pipe.o] Error 1make: ***
> Waiting for unfinished jobs....
>
>>
>> 3) whiteknight/io_userhandle
>
>
> Builds, but fails tests.  Summary from run on Darwin:
>
> t/pmc/packfileconstanttable.t             (Wstat: 11 Tests: 15 Failed: 0)
>   Non-zero wait status: 11
>   Parse errors: Bad plan.  You planned 17 tests but ran 15.
> t/compilers/pge/perl6regex/01-regex.t     (Wstat: 11 Tests: 584 Failed: 0)
>   Non-zero wait status: 11
>   Parse errors: No plan found in TAP output
> t/compilers/opsc/02-parse-all-ops.t       (Wstat: 11 Tests: 1 Failed: 0)
>   Non-zero wait status: 11
>   Parse errors: Bad plan.  You planned 19 tests but ran 1.
> t/compilers/opsc/08-emitter.t             (Wstat: 11 Tests: 0 Failed: 0)
>   Non-zero wait status: 11
>   Parse errors: Bad plan.  You planned 22 tests but ran 0.
> t/compilers/opsc/06-opsfile.t             (Wstat: 11 Tests: 0 Failed: 0)
>   Non-zero wait status: 11
>   Parse errors: No plan found in TAP output
> t/library/yaml_tiny.t                     (Wstat: 11 Tests: 29 Failed: 0)
>   Non-zero wait status: 11
>   Parse errors: No plan found in TAP output
> t/profiling/profiling.t                   (Wstat: 11 Tests: 5 Failed: 0)
>   Non-zero wait status: 11
>   Parse errors: Bad plan.  You planned 13 tests but ran 5.
>
> HTH
> jimk
>
> _______________________________________________
> http://lists.parrot.org/mailman/listinfo/parrot-dev