FixedFloatArray.sort() code review

Jonathan "Duke" Leto jonathan at leto.net
Sat Jan 26 00:54:08 UTC 2013


Howdy,

I would appreciate a code review here:

https://github.com/parrot/parrot/compare/ffa_sort

One thing that I don't quite feel great about is using == on FLOATVALs.
What is a better solution? Should I compare them to within some tolerance?

I would also love some additional tests that use negative numbers and other
edge cases. Feel free to commit to the branch.

Duke

-- 
Jonathan "Duke" Leto <jonathan at leto.net>
Leto Labs LLC http://labs.leto.net
209.691.DUKE http://dukeleto.pl
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.parrot.org/pipermail/parrot-dev/attachments/20130125/c7b514d0/attachment.html>


More information about the parrot-dev mailing list